Luca Boccassi
7ad06f1449
Problem: IPC event_closed logs -1 as the FD
...
Solution: take a copy of the file descriptor before setting it to
retired_fd.
2017-10-06 09:53:59 +01:00
Luca Boccassi
9be8cebd21
Merge pull request #2765 from GreatFruitOmsk/issue-2764
...
Problem: Race condition in IPC sockets
2017-10-06 09:25:33 +01:00
Ilya Kulakov
656cdb959a
Problem: Race condition in IPC sockets
...
Solution: Don't unlink file on close
File may not belong to the socket at that point.
2017-10-05 14:57:10 -07:00
Luca Boccassi
01a3f3955c
Merge pull request #2768 from ADDubovik/master
...
fix build for msvc2017
2017-10-05 21:18:19 +01:00
Alexander Dubovik
02c46463d7
fix build for msvc2017
2017-10-05 22:54:12 +03:00
Luca Boccassi
99c527702b
Merge pull request #2766 from hxw/master
...
add __FreeBSD__ to ifdefs
2017-10-05 09:17:51 +01:00
Christopher Hall
997825bdf1
add __FreeBSD__ to ifdefs
...
On FreeBSD the sysmbol __FreeBSD_kernel__ is only defines if a
specific param.h file is included, unlike Debian/kFreeBSD where this
symbol is always defined. So also compile the FreeBSD specific code
if __FreeBSD__ is defined for FreeBSD 11 & 12 compatibility.
Signed-off-by: Christopher Hall <hsw@ms2.hinet.net>
2017-10-03 15:30:42 +08:00
Luca Boccassi
44f96a3652
Merge pull request #2745 from sigiesec/rename-identity
...
Problem: term "identity" is confusing
2017-09-20 10:08:45 +02:00
Constantin Rack
f6688f0516
Merge pull request #2756 from bluca/reconnect_ivl_connect
...
Problem: zmq_connect fails after disconnect due to RECONNECT_IVL == -1
2017-09-20 07:46:19 +02:00
sigiesec
2c8a7223b8
Problem: remaining use of "identity"
...
Solution: replaced by "routing id"
2017-09-19 17:55:00 +02:00
sigiesec
7e3f4b1d32
Problem: ZMTP protocol broken w.r.t. Identity property
...
Solution: differentiate propertly between ZMTP property names and ZeroMQ API property names
2017-09-19 17:55:00 +02:00
sigiesec
a5e3a65ae2
Problem: inconsistency between zmq.h and zmq_draft.h
...
Solution: fix zmq_draft.h
2017-09-19 17:55:00 +02:00
sigiesec
4b821d8f84
Problem: remaining uses of "identity"
...
Solution: replaced by "routing id"
2017-09-19 17:54:59 +02:00
sigiesec
1414bf938c
Problem: use of unqualified "id" in code example
...
Solution: use "routing_id" instead
2017-09-19 17:54:52 +02:00
sigiesec
d6694e7d47
Problem: Use of "rid" in the docs
...
Solution: Replaced by "routing id"
2017-09-19 17:53:54 +02:00
sigiesec
12f62c74c1
Problem: docs refer to "Identity"
...
Solution: change docs to refer to "Routing id"
2017-09-19 17:53:54 +02:00
sigiesec
fab57634b4
Problem: Message metadata properties still refer to "identity"
...
Solution: Renamed, but support querying the property by its old name
2017-09-19 17:53:53 +02:00
sigiesec
27c7e52a5a
Problem: Usage of "rid" in server_t
...
Solution: Replaced by "routing_id"
2017-09-19 17:53:53 +02:00
sigiesec
41bae55af7
Problem: inconsistent naming related to routing ids
...
Solution: renamed routing_id fields in pipe_t, renamed ZMQ_CONNECT_RID to ZMQ_CONNECT_ROUTING_ID
2017-09-19 17:53:53 +02:00
sigiesec
9e7507b38b
Problem: term "identity" is confusing
...
Solution: replace by "routing id"
2017-09-19 17:53:44 +02:00
Luca Boccassi
76dfec7fc3
Merge pull request #2755 from sigiesec/client-side-error
...
Problem: tests where client should receive an ERROR sometimes do not
2017-09-19 16:48:37 +02:00
Luca Boccassi
edb4ca1023
Problem: zmq_connect fails after disconnect due to RECONNECT_IVL == -1
...
Solution: when a connection breaks and ZMQ_RECONNECT_IVL is set to -1,
which means a reconnection will not be attempted, send a message from
the I/O thread to the application thread to make the socket call
term_endpoint, which is the equivalent of manually calling
zmq_disconnect.
This way subsequent zmq_connect call to the same endpoint will attempt
again to do a connection.
Otherwise, for some socket types like SUBs, those new connects will
fail as the endpoint is recorded, despite the connection having been
permanently closed.
Add test cases to exercise this corner case with TCP and IPC.
2017-09-19 14:05:43 +01:00
sigiesec
e0243dcbca
Problem: tests where client should receive an ERROR sometimes do not
...
receive an ERROR (probably because the connection is closed before)
Solution: wait for client-side monitor events before closing the client
socket
Fixes #2705
2017-09-19 11:16:05 +02:00
Luca Boccassi
843e627bed
Merge pull request #2753 from zeromq/zap-domain-docs
...
Problem: documentation of ZMQ_ZAP_DOMAIN is wrong
2017-09-19 10:17:15 +02:00
sigiesec
7297df6278
Problem: documentation of ZMQ_ZAP_DOMAIN is wrong
...
Solution: fix documentation
2017-09-19 09:13:57 +02:00
Luca Boccassi
e2f2193bec
Merge pull request #2752 from sigiesec/test-no-zap-handler
...
Problem: missing tests and inconsistent behaviour for ZAP corner cases
2017-09-18 20:19:14 +02:00
sigiesec
77f76a49b2
Problem: no tests for cases 5 and 6 of #2711
...
Solution: added tests
2017-09-18 18:43:32 +02:00
sigiesec
e546f9296e
Problem: duplicated code & inconsistent behaviour between
...
mechanisms
Solution: uniformly require a ZAP domain to be set to activate ZAP
handling, clarify comment on Stonehouse pattern
2017-09-18 17:01:38 +02:00
sigiesec
ee8b8bd29c
Problem: no test for ZAP handler terminating in flight
...
Solution: added test & some improvements of test utils
2017-09-18 16:54:03 +02:00
sigiesec
a5f94cb610
Problem: tests without ZAP handler are failing
...
Solution: emit events as expected by tests, and refuse connections when
ZAP is required but no handler started
Addresses #2711 partially
2017-09-18 12:58:09 +02:00
sigiesec
13b972b226
Problem: no tests without ZAP handler where one is expected
...
Solution: added test case for NULL/PLAIN/CURVE
2017-09-18 10:26:28 +02:00
Jim Klimov
9071265c02
Merge pull request #2751 from bluca/centos6
...
Problem: CentOS 6 build fails
2017-09-18 01:32:49 +02:00
Luca Boccassi
40c1a3ab7e
Problem: CentOS 6 build fails
...
Solution: use same autoconf workaround as for Debian 7, and manually
create the config directory
2017-09-17 20:44:28 +01:00
Luca Boccassi
2e167886cf
Merge pull request #2749 from reza-ebrahimi/master
...
Update AUTHERS File
2017-09-15 00:10:31 +02:00
Luca Boccassi
23c2f4987b
Merge pull request #2748 from tkoeppe/relicense
...
RELICENSE: Google, Inc.
2017-09-14 23:54:41 +02:00
Reza Ebrahimi
633325e0bc
Update AUTHERS File
2017-09-14 22:04:26 +04:30
Thomas Köppe
21d78f4789
RELICENSE: Google, Inc.
...
Relevant commits: ddb82a546b
, 68f5926ec6
Also adds AUTHORS entry that should have been part of the previous commits.
2017-09-13 16:31:38 +01:00
Luca Boccassi
5de2a82be8
Merge pull request #2744 from msune/refactor_poller_wait
...
Problem: duplicated socket_poller::wait() code
2017-09-13 00:48:26 +02:00
Marc Sune
5b92989540
Problem: duplicated socket_poller::wait() code
...
zmq::socket_poller_t::wait() had an important set of common lines
between POLL and SELECT variant.
Solution: refactor zmq::socket_poller_t::wait() and add the
following methods:
zmq::socket_poller_t::zero_trail_events()
zmq::socket_poller_t::check_events()
zmq::socket_poller_t::adjust_timeout()
Signed-off-by: Marc Sune <mardevel@gmail.com>
2017-09-12 21:47:57 +02:00
Constantin Rack
18498f620f
Merge pull request #2746 from zeromq/revert-2743-rename-identity
...
Revert "Problem: term "identity" is confusing"
2017-09-07 15:24:07 +02:00
Doron Somech
af03241dcb
Revert "Problem: term "identity" is confusing"
2017-09-07 15:47:43 +03:00
Doron Somech
08b01a5108
Merge pull request #2743 from sigiesec/rename-identity
...
Problem: term "identity" is confusing
2017-09-07 12:58:56 +03:00
sigiesec
cd55c62499
Problem: use of unqualified "id" in code example
...
Solution: use "routing_id" instead
2017-09-07 11:21:13 +02:00
sigiesec
0874eec803
Problem: Use of "rid" in the docs
...
Solution: Replaced by "routing id"
2017-09-07 11:18:50 +02:00
sigiesec
f174003740
Problem: docs refer to "Identity"
...
Solution: change docs to refer to "Routing id"
2017-09-07 11:09:18 +02:00
sigiesec
deae59dca9
Problem: Message metadata properties still refer to "identity"
...
Solution: Renamed, but support querying the property by its old name
2017-09-07 10:33:25 +02:00
sigiesec
ae2ea1a655
Problem: Usage of "rid" in server_t
...
Solution: Replaced by "routing_id"
2017-09-07 10:33:25 +02:00
sigiesec
e00131dd43
Problem: inconsistent naming related to routing ids
...
Solution: renamed routing_id fields in pipe_t, renamed ZMQ_CONNECT_RID to ZMQ_CONNECT_ROUTING_ID
2017-09-07 10:33:13 +02:00
sigiesec
1daf83079a
Problem: term "identity" is confusing
...
Solution: replace by "routing id"
2017-09-06 17:45:56 +02:00
Doron Somech
876d90732d
Merge pull request #2741 from bluca/proxy_stats_typos
...
Problems: typos in proxy_steerable stats
2017-09-06 12:04:57 +03:00