generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-10-28 11:31:56 +01:00
Code Issues Projects Releases Wiki Activity

Don't call memcpy with 0 size and NULL pointer(s)

Browse Source 
It's undefined behavior, and ubsan flags it.
This commit is contained in:
Brian Silverman
2016-02-05 14:04:22 -05:00
parent c9c9a777d6
commit f4fe375bd1
8 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/req.cpp
View File

@@ -204,7 +204,8 @@ bool zmq::req_t::xhas_out ()
int zmq::req_t::xsetsockopt (int option_, const void *optval_, size_t optvallen_)
{
bool is_int = (optvallen_ == sizeof (int));
int value = is_int? *((int *) optval_): 0;
int value = 0;
if (is_int) memcpy(&value, optval_, sizeof (int));
switch (option_) {
case ZMQ_REQ_CORRELATE:
if (is_int && value >= 0) {