From b2010432c726fb8e092c2c5aacca5adb560aa1dd Mon Sep 17 00:00:00 2001
From: William Swanson <swansontec@gmail.com>
Date: Mon, 2 Nov 2015 14:59:15 -0800
Subject: [PATCH] Do not crash on unusual connection-failure cases

Only assert on errors we know are our fault,
instead of trying to whitelist every possible network-related failure.
This makes ZeroMQ more portable to other platforms
where the possible errors are different.

In particular, the previous code would often die under iOS.
---
 src/tcp_connecter.cpp | 26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)

diff --git a/src/tcp_connecter.cpp b/src/tcp_connecter.cpp
index b8d62a2d..dd94a93e 100644
--- a/src/tcp_connecter.cpp
+++ b/src/tcp_connecter.cpp
@@ -347,16 +347,10 @@ zmq::fd_t zmq::tcp_connecter_t::connect ()
 #ifdef ZMQ_HAVE_WINDOWS
     zmq_assert (rc == 0);
     if (err != 0) {
-        if (err != WSAECONNREFUSED
-            && err != WSAETIMEDOUT
-            && err != WSAECONNABORTED
-            && err != WSAEHOSTUNREACH
-            && err != WSAENETUNREACH
-            && err != WSAENETDOWN
-            && err != WSAEACCES
-            && err != WSAEINVAL
-            && err != WSAEADDRINUSE
-			&& err != WSAEADDRNOTAVAIL)
+        if (err == WSAEBADF ||
+            err == WSAENOPROTOOPT ||
+            err == WSAENOTSOCK ||
+            err == WSAENOBUFS)
         {
             wsa_assert_no (err);
         }
@@ -370,14 +364,10 @@ zmq::fd_t zmq::tcp_connecter_t::connect ()
     if (err != 0) {
         errno = err;
         errno_assert (
-            errno == ECONNREFUSED ||
-            errno == ECONNRESET ||
-            errno == ETIMEDOUT ||
-            errno == EHOSTUNREACH ||
-            errno == ENETUNREACH ||
-            errno == ENETDOWN ||
-            errno == EINVAL ||
-			errno == EADDRNOTAVAIL);
+            errno != EBADF &&
+            errno != ENOPROTOOPT &&
+            errno != ENOTSOCK &&
+            errno != ENOBUFS);
         return retired_fd;
     }
 #endif