generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-03-04 07:27:26 +01:00
Code Issues Projects Releases Wiki Activity

Handle tcp self connection issues (#4599)

Browse Source
This commit is contained in:
James Harvey 2023-10-10 14:46:48 +01:00 committed by GitHub
parent dbb7e3dc01
commit 9d31965548
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/endpoint.hpp
View File

@ -29,6 +29,8 @@ struct endpoint_uri_pair_t
return local_type == endpoint_type_bind ? local : remote; return local_type == endpoint_type_bind ? local : remote;
} }
const bool clash () const { return local == remote; }
std::string local, remote; std::string local, remote;
endpoint_type_t local_type; endpoint_type_t local_type;
}; };

10
src/stream_engine_base.cpp
View File

@ -294,8 +294,14 @@ bool zmq::stream_engine_base_t::in_event_internal ()
// or the session has rejected the message. // or the session has rejected the message.
if (rc == -1) { if (rc == -1) {
if (errno != EAGAIN) { if (errno != EAGAIN) {
error (protocol_error); // In cases where the src/dst have the same IP and the dst uses an ephemeral port, reconnection
return false; // eventually results in the src and dest IP and port clashing (google tcp self connection)
// While this is a protocol_error (you have the single zmq socket handshaking with itself)
// we do not want to to stop reconnection from happening
if (!_endpoint_uri_pair.clash ()) {
error (protocol_error);
return false;
}
} }
_input_stopped = true; _input_stopped = true;
reset_pollin (_handle); reset_pollin (_handle);