From 4d3516f634a4a5e3f522f5cb277da38b188d32eb Mon Sep 17 00:00:00 2001
From: Simon Giesecke <simon.giesecke@gmail.com>
Date: Wed, 16 May 2018 09:45:52 +0200
Subject: [PATCH] Problem: no static analysis under Linux

Solution: activate clang-tidy, scan-build and sonar-scanner
---
 .travis.yml              | 20 ++++++++++++++
 builds/cmake/ci_build.sh | 58 ++++++++++++++++++++++++++++++++++++----
 2 files changed, 73 insertions(+), 5 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 9001d948..5ba5f185 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -93,6 +93,18 @@ matrix:
         - llvm-toolchain-trusty-5.0
       packages:
         - clang-5.0
+  - env: BUILD_TYPE=cmake CLANG_TIDY=/usr/bin/clang-tidy-6.0 CC=clang-6.0 CXX=clang++-6.0
+    os: linux
+    compiler: clang
+    addons:
+      apt:
+        sources:
+          - ubuntu-toolchain-r-test
+          - llvm-toolchain-trusty-6.0
+        packages:
+          - clang-6.0
+          - clang-tools-6.0
+          - clang-tidy-6.0
   - env: BUILD_TYPE=default POLLER=poll
     os: linux
   - env: BUILD_TYPE=default POLLER=select
@@ -103,6 +115,14 @@ sudo: false
 before_install:
 - if [ $TRAVIS_OS_NAME == "osx" -a $BUILD_TYPE == "android" ] ; then brew update; brew install binutils ; fi
 - if [ $TRAVIS_OS_NAME == "osx" -a $CURVE == "libsodium" ] ; then brew update; brew install libsodium ; fi
+- if [ -n "$CLANG_TIDY" ] ; then
+    curl -L https://sonarcloud.io/static/cpp/build-wrapper-linux-x86.zip -o build-wrapper-linux-x86.zip ;
+    unzip build-wrapper-linux-x86.zip ;
+    export SONARCLOUD_BUILD_WRAPPER_PATH="$(pwd)/build-wrapper-linux-x86/" ;
+    curl -L https://sonarsource.bintray.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-3.1.0.1141-linux.zip -o sonar-scanner-cli.zip ;
+    unzip sonar-scanner-cli.zip ;
+    export SONAR_SCANNER_CLI_PATH="$(pwd)/sonar-scanner-3.1.0.1141-linux/bin/" ;
+  fi
 
 before_script:
 # ZMQ stress tests need more open socket (files) than the usual default
diff --git a/builds/cmake/ci_build.sh b/builds/cmake/ci_build.sh
index b87d9c1d..72712661 100755
--- a/builds/cmake/ci_build.sh
+++ b/builds/cmake/ci_build.sh
@@ -1,12 +1,12 @@
 #!/usr/bin/env bash
 
-set -x
+set -x -e
 
 cd ../..
 
 # always install custom builds from dist
 # to make sure that `make dist` doesn't omit any files required to build & test
-if [ -z $DO_CLANG_FORMAT_CHECK ]; then
+if [ -z $DO_CLANG_FORMAT_CHECK -a -z $CLANG_TIDY ]; then
     ./autogen.sh
     ./configure
     make -j5 dist-gzip
@@ -15,7 +15,7 @@ if [ -z $DO_CLANG_FORMAT_CHECK ]; then
     cd zeromq-$V
 fi
 
-mkdir tmp
+mkdir tmp || true
 BUILD_PREFIX=$PWD/tmp
 
 CONFIG_OPTS=()
@@ -47,15 +47,63 @@ elif [ $CURVE == "libsodium" ]; then
     fi
 fi
 
+CMAKE_PREFIXES=()
+MAKE_PREFIXES=()
+PARALLEL_MAKE_OPT="-j5"
+if [ -n "$CLANG_TIDY" ] ; then
+    CMAKE_OPTS+=("-DCMAKE_CXX_CLANG_TIDY:STRING=${CLANG_TIDY}")
+    if [ -n ${SONARCLOUD_BUILD_WRAPPER_PATH} ] ; then
+        MAKE_PREFIXES+=("${SONARCLOUD_BUILD_WRAPPER_PATH}build-wrapper-linux-x86-64")
+        MAKE_PREFIXES+=("--out-dir")
+        MAKE_PREFIXES+=("${TRAVIS_BUILD_DIR}/bw-output")
+        
+    fi
+    CMAKE_PREFIXES+=("scan-build-6.0")
+    MAKE_PREFIXES+=("scan-build-6.0")
+    MAKE_PREFIXES+=("-plist-html")
+    SCAN_BUILD_OUTPUT="$(pwd)/scan-build-report"
+    MAKE_PREFIXES+=("-o ${SCAN_BUILD_OUTPUT}")
+    # TODO this does not work with sonarcloud.io as it misses the sonar-cxx plugin
+    #MAKE_PREFIXES+=("-plist")
+    IFS="/" read -ra GITHUB_USER <<< "${TRAVIS_REPO_SLUG}"
+    PARALLEL_MAKE_OPT=""
+fi
+
 # Build, check, and install from local source
 mkdir build_cmake
 cd build_cmake
-if [ "$DO_CLANG_FORMAT_CHECK" -eq "1" ] ; then
+if [ "$DO_CLANG_FORMAT_CHECK" = "1" ] ; then
     if ! ( PKG_CONFIG_PATH=${BUILD_PREFIX}/lib/pkgconfig cmake "${CMAKE_OPTS[@]}" .. && make clang-format-check) ; then
         make clang-format-diff
         exit 1
     fi
 else
+    if [ -n "$CLANG_TIDY" ] ; then
+        ${CLANG_TIDY} -explain-config
+    fi
+
     export CTEST_OUTPUT_ON_FAILURE=1
-    ( PKG_CONFIG_PATH=${BUILD_PREFIX}/lib/pkgconfig cmake "${CMAKE_OPTS[@]}" .. && make -j5 all VERBOSE=1 && make install && make -j5 test ARGS="-V" ) || exit 1
+    PKG_CONFIG_PATH=${BUILD_PREFIX}/lib/pkgconfig ${CMAKE_PREFIXES[@]} cmake "${CMAKE_OPTS[@]}" ..
+    ${MAKE_PREFIXES[@]} make ${PARALLEL_MAKE_OPT} all VERBOSE=1 | tee clang-tidy-report
+    
+    if [ -n "${SONAR_SCANNER_CLI_PATH}" ] ; then
+        find ${SCAN_BUILD_OUTPUT} || echo "WARNING: ${SCAN_BUILD_OUTPUT} does not exist"
+    
+        ${SONAR_SCANNER_CLI_PATH}sonar-scanner \
+            -Dsonar.projectKey=libzmq-clang \
+            -Dsonar.organization=${GITHUB_USER}-github \
+            -Dsonar.projectBaseDir=.. \
+            -Dsonar.sources=${TRAVIS_BUILD_DIR}/include,${TRAVIS_BUILD_DIR}/src,${TRAVIS_BUILD_DIR}/tests,${TRAVIS_BUILD_DIR}/unittests \
+            -Dsonar.cfamily.build-wrapper-output=${TRAVIS_BUILD_DIR}/bw-output \
+            -Dsonar.host.url=https://sonarcloud.io \
+            -Dsonar.login=${SONARQUBE_TOKEN}
+
+            # TODO this does not work with sonarcloud.io as it misses the sonar-cxx plugin
+            # -Dsonar.cxx.clangtidy.reportPath=clang-tidy-report \
+            # -Dsonar.cxx.clangsa.reportPath=*.plist \
+            
+    fi
+
+    make install
+    make ${PARALLEL_MAKE_OPT} test ARGS="-V"
 fi