generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-10-30 13:47:13 +01:00
Code Issues Projects Releases Wiki Activity

Problem: invoking the conditional variable for zero time is expensive

Browse Source 
Solution: for zero timeout, unlock and relock immediately instead of timedwait
This commit is contained in:
somdoron
2019-02-06 21:07:22 +02:00
parent 9b1627f041
commit 462dd36d0e
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/mailbox_safe.cpp
View File

@@ -99,11 +99,19 @@ int zmq::mailbox_safe_t::recv (command_t *cmd_, int timeout_)
if (_cpipe.read (cmd_)) if (_cpipe.read (cmd_))
return 0; return 0;
// Wait for signal from the command sender. // If the timeout is zero, it will be quicker to release the lock, giving other a chance to send a command
int rc = _cond_var.wait (_sync, timeout_); // and immediately relock it.
if (rc == -1) { if (timeout_ == 0) {
errno_assert (errno == EAGAIN || errno == EINTR); _sync->unlock ();
return -1; _sync->lock ();
}
else {
// Wait for signal from the command sender.
int rc = _cond_var.wait (_sync, timeout_);
if (rc == -1) {
errno_assert (errno == EAGAIN || errno == EINTR);
return -1;
}
} }
// Another thread may already fetch the command // Another thread may already fetch the command