generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-01-31 14:39:55 +01:00
Code Issues Projects Releases Wiki Activity

Regression: Android build fails with libsodium.

Browse Source 
Scenario:
```
export CURL=libsodium
cd zyre/builds/android
./ci_build.sh
```

Result:
```
Android (arm) build failed for the following reasons:
  Found no library named libzmq.so libsodium.so
    /home/stephan/git/zproject-android-testing/libzmq/builds/android/prefix/arm/lib/libzmq.so libsodium.so
```

Caused by PR #4437, where the 2nd commit was to fix Sonatype findings.

Lesson learnt: Not always a good idea to add double quotes around variables ...

Solution: Make VERIFY an array, so that Sonatype won't complain.
This commit is contained in:
Stephan Guilloux (cos) 2022-10-12 02:42:28 +02:00
parent c19f83027d
commit 3022e7e099
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
builds/android/build.sh
View File

@ -55,12 +55,12 @@ if [[ $ANDROID_BUILD_CLEAN ]]; then
rm -rf "${ANDROID_BUILD_PREFIX}"/* rm -rf "${ANDROID_BUILD_PREFIX}"/*
fi fi
VERIFY=("libzmq.so")
if [ -z $CURVE ]; then if [ -z $CURVE ]; then
CURVE="--disable-curve" CURVE="--disable-curve"
VERIFY="libzmq.so"
elif [ $CURVE == "libsodium" ]; then elif [ $CURVE == "libsodium" ]; then
CURVE="--with-libsodium=yes" CURVE="--with-libsodium=yes"
VERIFY="libzmq.so libsodium.so" VERIFY+=("libsodium.so")
## ##
# Build libsodium from latest master branch # Build libsodium from latest master branch
@ -84,13 +84,12 @@ elif [ $CURVE == "libsodium" ]; then
elif [ $CURVE == "tweetnacl" ]; then elif [ $CURVE == "tweetnacl" ]; then
# Default # Default
CURVE="" CURVE=""
VERIFY="libzmq.so"
fi fi
## ##
# Build libzmq from local source # Build libzmq from local source
(android_build_verify_so ${VERIFY} &> /dev/null) || { (android_build_verify_so "${VERIFY[@]}" &> /dev/null) || {
rm -rf "${cache}/libzmq" rm -rf "${cache}/libzmq"
(cp -r ../.. "${cache}/libzmq" && cd "${cache}/libzmq" && ( make clean || : )) (cp -r ../.. "${cache}/libzmq" && cd "${cache}/libzmq" && ( make clean || : ))
@ -118,5 +117,5 @@ cp "${ANDROID_STL_ROOT}/${ANDROID_STL}" "${ANDROID_BUILD_PREFIX}/lib/."
## ##
# Verify shared libraries in prefix # Verify shared libraries in prefix
android_build_verify_so "${VERIFY}" "${ANDROID_STL}" android_build_verify_so "${VERIFY[@]}" "${ANDROID_STL}"
echo "LIBZMQ (${BUILD_ARCH}) - Android build successful" echo "LIBZMQ (${BUILD_ARCH}) - Android build successful"