generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-10-28 19:52:00 +01:00
Code Issues Projects Releases Wiki Activity

Use memcpy instead of assuming option values are aligned

Browse Source 
Otherwise, it's undefined behavior. ubsan catches alignment issues in
the libzmq test suite without this.
This commit is contained in:
Brian Silverman
2016-02-06 22:20:42 -05:00
parent ffe4a1c615
commit 273b54715e
5 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/req.cpp
View File

@@ -204,7 +204,8 @@ bool zmq::req_t::xhas_out ()
int zmq::req_t::xsetsockopt (int option_, const void *optval_, size_t optvallen_)
{
bool is_int = (optvallen_ == sizeof (int));
int value = is_int? *((int *) optval_): 0;
int value = 0;
if (is_int) memcpy(&value, optval_, sizeof (int));
switch (option_) {
case ZMQ_REQ_CORRELATE: