From bbe85ef599a53cf76325641934f8c95329c83a82 Mon Sep 17 00:00:00 2001 From: "Nektarios K. Papadopoulos" Date: Thu, 26 Apr 2007 10:05:22 +0000 Subject: [PATCH] Fix a bug in makeAction * upnp/src/api/upnptools.c: Avoid extra call to va_arg after consuming all arguments. git-svn-id: https://pupnp.svn.sourceforge.net/svnroot/pupnp/trunk@161 119443c7-1b9e-41f8-b6fc-b9c35fce742c --- upnp/src/api/upnptools.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/upnp/src/api/upnptools.c b/upnp/src/api/upnptools.c index 46329f3..9cb220e 100644 --- a/upnp/src/api/upnptools.c +++ b/upnp/src/api/upnptools.c @@ -298,7 +298,7 @@ makeAction( IN int response, if( NumArg > 0 ) { //va_start(ArgList, Arg); ArgName = Arg; - while( Idx++ != NumArg ) { + for(;;;) { ArgValue = va_arg( ArgList, const char * ); if( ArgName != NULL ) { @@ -313,6 +313,10 @@ makeAction( IN int response, ixmlNode_appendChild( node, ( IXML_Node * ) Ele ); } + if ( ++Idx == NumArg ) { + break; + } + ArgName = va_arg( ArgList, const char * ); } //va_end(ArgList);