generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Avoid a dangling pointer.

Browse Source 
git-svn-id: https://pupnp.svn.sourceforge.net/svnroot/pupnp/trunk@439 119443c7-1b9e-41f8-b6fc-b9c35fce742c
This commit is contained in:
Marcelo Roberto Jimenez
2008-06-12 13:58:08 +00:00
parent 9f96b04831
commit a6ba868e58
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ixml/src/ixmlparser.c
View File

@@ -1824,15 +1824,12 @@ static int Parser_xmlNamespace(
if (pCur->namespaceUri != NULL) { if (pCur->namespaceUri != NULL) {
free(pCur->namespaceUri); free(pCur->namespaceUri);
} }
/* here it goes to segfault on "" when not copying */ pCur->namespaceUri = safe_strdup(newNode->nodeValue);
if (newNode->nodeValue){
pCur->namespaceUri = safe_strdup( newNode->nodeValue );
if (pCur->namespaceUri == NULL) { if (pCur->namespaceUri == NULL) {
ret = IXML_INSUFFICIENT_MEMORY; ret = IXML_INSUFFICIENT_MEMORY;
line = __LINE__; line = __LINE__;
goto ExitFunction; goto ExitFunction;
} }
}
} else if (strncmp(newNode->nodeName, "xmlns:", strlen("xmlns:")) == 0) { } else if (strncmp(newNode->nodeName, "xmlns:", strlen("xmlns:")) == 0) {
/* namespace definition */ /* namespace definition */
ret = Parser_setNodePrefixAndLocalName(newNode); ret = Parser_setNodePrefixAndLocalName(newNode);