generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not clear buffer before snprintf.

Browse Source 
It had no effect since snprintf can overwrite whole buffer.
This commit is contained in:
Yoichi NAKAYAMA
2012-03-11 01:04:24 +09:00
parent 87d1d3c3ec
commit a0dc3482dc
6 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
upnp/src/gena/gena_ctrlpt.c
View File

@@ -294,7 +294,6 @@ static int gena_subscribe(
http_parser_t response;
int rc = 0;
memset(timeout_str, 0, sizeof(timeout_str));
UpnpString_clear(sid);
/* request timeout to string */
@@ -302,6 +301,7 @@ static int gena_subscribe(
timeout = &local_timeout;
}
if (*timeout < 0) {
memset(timeout_str, 0, sizeof(timeout_str));
strncpy(timeout_str, "infinite", sizeof(timeout_str) - 1);
} else if(*timeout < CP_MINIMUM_SUBSCRIPTION_TIME) {
rc = snprintf(timeout_str, sizeof(timeout_str),