generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SF Bug Tracker id 3489999 - UpnpString leaks in genaSubscribe()

Browse Source 
Submitted: Yoichi NAKAYAMA ( yoichi ) - 2012-02-21 07:06:35 PST

In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed if ScheduleGenaAutoRenew
returns UPNP_E_SUCCESS.

This fixes the an issue introduced by the previous fix.
This commit is contained in:
Marcelo Roberto Jimenez
2012-02-26 21:36:24 -03:00
parent 76c7fc26eb
commit 81da3d004a
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ChangeLog
View File

@@ -299,6 +299,18 @@ Version 1.8.0
Version 1.6.16 Version 1.6.16
******************************************************************************* *******************************************************************************
2012-02-24 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
SF Bug Tracker id 3489999 - UpnpString leaks in genaSubscribe()
Submitted: Yoichi NAKAYAMA ( yoichi ) - 2012-02-21 07:06:35 PST
In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed if ScheduleGenaAutoRenew
returns UPNP_E_SUCCESS.
This fixes the an issue introduced by the previous fix.
2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net> 2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
SF Bug Tracker id 3489999 - UpnpString leaks in genaSubscribe() SF Bug Tracker id 3489999 - UpnpString leaks in genaSubscribe()

1
upnp/src/gena/gena_ctrlpt.c
View File

@@ -565,6 +565,7 @@ int genaSubscribe(
error_handler: error_handler:
UpnpString_delete(ActualSID); UpnpString_delete(ActualSID);
UpnpString_delete(EventURL); UpnpString_delete(EventURL);
if (return_code != UPNP_E_SUCCESS)
GenlibClientSubscription_delete(newSubscription); GenlibClientSubscription_delete(newSubscription);
HandleUnlock(); HandleUnlock();
SubscribeUnlock(); SubscribeUnlock();