generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SF Bug Tracker: UpnpString leaks in genaSubscribe()

Browse Source 
In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed.
(cherry picked from commit 2940cbf94a81bdfebb2e6a61a4d2a5488050748a)
This commit is contained in:
Marcelo Roberto Jimenez 2012-02-23 16:30:19 -02:00
parent cf0f53bb63
commit 7641dab89e
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -255,6 +255,14 @@ Version 1.8.0
Version 1.6.16
*******************************************************************************
2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
SF Bug Tracker: UpnpString leaks in genaSubscribe()
In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed if ScheduleGenaAutoRenew
returns UPNP_E_SUCCESS.
2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
Revert cb89781a55466703763c1b0ee67094eb401ddfe9 as suggested by

6
upnp/src/gena/gena_ctrlpt.c
View File

@ -516,9 +516,9 @@ int genaSubscribe(
HandleReadLock();
/* validate handle */
if (GetHandleInfo(client_handle, &handle_info) != HND_CLIENT) {
HandleUnlock();
return GENA_E_BAD_HANDLE;
return_code = GENA_E_BAD_HANDLE;
SubscribeLock();
goto error_handler;
}
HandleUnlock();