generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix for return value of UpnpResolveURL and UpnpResolveURL2

Browse Source 
SF Bug tracker, ID: 3469344
	Submitted: dimmman ( dimmman ) - 2012-01-04 01:44:29 PST
	Details: Looking at the code (v1.6.14, upnptools.c) for UpnpResolveURL
	and UpnpResolveURL2 it shows that the ExitFunction: always returns
	UPNP_E_SUCCESS.

	I'm farily sure it's a simple mistake that should have been "return ret;"
	in both cases.

	Br,
	Jonny
This commit is contained in:
Marcelo Roberto Jimenez 2012-01-09 08:58:03 -02:00
parent b35761e893
commit 3b33626e2f
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ChangeLog
View File

@ -2,6 +2,19 @@
Version 1.6.15 Version 1.6.15
******************************************************************************* *******************************************************************************
2012-01-09 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
SF Bug tracker, ID: 3469344
Submitted: dimmman ( dimmman ) - 2012-01-04 01:44:29 PST
Details: Looking at the code (v1.6.14, upnptools.c) for UpnpResolveURL
and UpnpResolveURL2 it shows that the ExitFunction: always returns
UPNP_E_SUCCESS.
I'm farily sure it's a simple mistake that should have been "return ret;"
in both cases.
Br,
Jonny
******************************************************************************* *******************************************************************************
Version 1.6.14 Version 1.6.14

4
upnp/src/api/upnptools.c
View File

@ -157,7 +157,7 @@ int UpnpResolveURL(
ret = UPNP_E_INVALID_URL; ret = UPNP_E_INVALID_URL;
ExitFunction: ExitFunction:
return UPNP_E_SUCCESS; return ret;
} }
@ -177,7 +177,7 @@ int UpnpResolveURL2(
ret = UPNP_E_INVALID_URL; ret = UPNP_E_INVALID_URL;
ExitFunction: ExitFunction:
return UPNP_E_SUCCESS; return ret;
} }