generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SF Bug Tracker: UpnpString leaks in genaSubscribe()

Browse Source 
In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed.
This commit is contained in:
Marcelo Roberto Jimenez
2012-02-23 16:30:19 -02:00
parent d87c966ec5
commit 2940cbf94a
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@@ -2,6 +2,14 @@
Version 1.6.16 Version 1.6.16
******************************************************************************* *******************************************************************************
2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
SF Bug Tracker: UpnpString leaks in genaSubscribe()
In genaSubscribe() (defined in upnp/src/gena/gena_ctrlpt.c),
ActualSID and EventURL will not be freed if ScheduleGenaAutoRenew
returns UPNP_E_SUCCESS.
2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net> 2012-02-23 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>
Revert cb89781a55466703763c1b0ee67094eb401ddfe9 as suggested by Revert cb89781a55466703763c1b0ee67094eb401ddfe9 as suggested by

6
upnp/src/gena/gena_ctrlpt.c
View File

@@ -520,9 +520,9 @@ int genaSubscribe(
HandleReadLock(); HandleReadLock();
/* validate handle */ /* validate handle */
if (GetHandleInfo(client_handle, &handle_info) != HND_CLIENT) { if (GetHandleInfo(client_handle, &handle_info) != HND_CLIENT) {
HandleUnlock(); return_code = GENA_E_BAD_HANDLE;
SubscribeLock();
return GENA_E_BAD_HANDLE; goto error_handler;
} }
HandleUnlock(); HandleUnlock();