generic-library/libupnp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SF Bug Tracker id 3498436 - Memory leak in Parser_processAttributeName

Browse Source 
Submitted: Fabrice Fontaine ( ffontaine ) - 2012-03-07 02:30:57 PST

attr is not freed if ixmlNode_setNodeProperties or
ixmlNode_setAttributeNode return an error in
Parser_processAttributeName.
This commit is contained in:
Fabrice Fontaine 2012-03-07 12:36:45 +01:00
parent 288ef35cee
commit 268abf72fb
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ChangeLog
View File

@ -2,6 +2,16 @@
Version 1.6.16 Version 1.6.16
******************************************************************************* *******************************************************************************
2012-03-07 Fabrice Fontaine <fabrice.fontaine(at)orange.com>
SF Bug Tracker id 3498436 - Memory leak in Parser_processAttributeName
Submitted: Fabrice Fontaine ( ffontaine ) - 2012-03-07 02:30:57 PST
attr is not freed if ixmlNode_setNodeProperties or
ixmlNode_setAttributeNode return an error in
Parser_processAttributeName.
2012-03-07 Fabrice Fontaine <fabrice.fontaine(at)orange.com> 2012-03-07 Fabrice Fontaine <fabrice.fontaine(at)orange.com>
Fixing an error in d6db7c555d0f11856ce5e3e479b16a4cf4689107 commit Fixing an error in d6db7c555d0f11856ce5e3e479b16a4cf4689107 commit

4
ixml/src/ixmlparser.c
View File

@ -2054,11 +2054,15 @@ static int Parser_processAttributeName(
rc = ixmlNode_setNodeProperties( ( IXML_Node * ) attr, newNode ); rc = ixmlNode_setNodeProperties( ( IXML_Node * ) attr, newNode );
if( rc != IXML_SUCCESS ) { if( rc != IXML_SUCCESS ) {
ixmlAttr_free( attr );
return rc; return rc;
} }
rc = ixmlElement_setAttributeNode( rc = ixmlElement_setAttributeNode(
(IXML_Element *)xmlParser->currentNodePtr, attr, NULL ); (IXML_Element *)xmlParser->currentNodePtr, attr, NULL );
if( rc != IXML_SUCCESS ) {
ixmlAttr_free( attr );
}
return rc; return rc;
} }