2006-06-06 10:51:22 +02:00
|
|
|
|
|
|
|
|
libupnp was originally written by Intel Corporation.
|
|
|
|
|
|
|
|
|
|
Many people further contributed to libupnp by reporting problems,
|
|
|
|
|
suggesting various improvements or submitting actual code.
|
|
|
|
|
Here is a list of these people. Help us keep it complete and
|
|
|
|
|
exempt of errors.
|
|
|
|
|
|
2007-11-06 03:29:03 +01:00
|
|
|
- Alex (afaucher)
|
2008-03-21 00:34:45 +01:00
|
|
|
- Andre Sodermans (wienerschnitzel)
|
2010-05-07 13:20:00 +02:00
|
|
|
- Anthony Viallard (homer242)
|
2008-04-10 19:36:21 +02:00
|
|
|
- Apostolos Syropoulos
|
2006-07-07 09:16:58 +02:00
|
|
|
- Arno Willig
|
2007-05-26 07:54:23 +02:00
|
|
|
- Bob Ciora
|
2010-03-21 20:52:22 +01:00
|
|
|
- Carlo Parata
|
2010-11-01 03:43:20 +01:00
|
|
|
- Carl Benson
|
2010-09-07 19:47:12 +02:00
|
|
|
- Chandra (inactiveneurons)
|
2006-07-07 09:16:58 +02:00
|
|
|
- Chaos
|
2008-04-25 15:32:05 +02:00
|
|
|
- Charles Nepveu (cnepveu)
|
2008-01-13 06:33:35 +01:00
|
|
|
- Chris Pickel
|
SF Bug Tracker [ 3007407 ] Service traversal issue in AdvertiseAndReply()
Submitted: Chuck Thomason ( cyt4 ) - 2010-05-26 15:07:39 UTC
When the UPnP server is started, one alive message is broadcast for each
service in each device. It appears that libupnp's implementation of the
alive message generation does not correctly navigate the XML description
document when locating the services. This can result in the wrong UDN
being used in the alive message sent for a service.
In my specific case (see attached XML), the root EchoSTB device contains
no services, but its embedded MediaServer device contains 2 services.
When the existing libupnp code traverses the EchoSTB device in the XML,
it searches the global list of serviceLists within the document instead
of searching for a serviceList that is its direct child node. The
ContentDirectory and ConnectionManager services are then announced with
the UDN of EchoSTB1 (the root device) instead of with the UDN of
MediaServer, which is actually their parent device.
I discovered this behavior using libupnp-1.6.6. I have generated a patch
against branch-1.6.x that corrects the XML navigation such that all
services are traversed from their parent device, which results in the
correct UDN being sent in the alive message for each service. I built
from branch-1.6.x without this patch, tested, and confirmed that the
issue still exists as I observed it in libupnp-1.6.6. I then built
from branch-1.6.x with this patch, tested, and confirmed that the
issue was resolved.
Thanks,
Chuck Thomason
git-svn-id: https://pupnp.svn.sourceforge.net/svnroot/pupnp/trunk@552 119443c7-1b9e-41f8-b6fc-b9c35fce742c
2010-06-17 19:02:03 +02:00
|
|
|
- Chuck Thomason (cyt4)
|
2007-04-19 15:05:33 +02:00
|
|
|
- Craig Nelson
|
2010-08-22 13:32:09 +02:00
|
|
|
- David Blanchet
|
2006-12-23 22:05:50 +01:00
|
|
|
- David Maass
|
2007-04-17 05:55:20 +02:00
|
|
|
- Emil Ljungdahl
|
2006-12-23 21:37:46 +01:00
|
|
|
- Erik Johansson
|
|
|
|
|
- Eric Tanguy
|
|
|
|
|
- Erwan Velu
|
2007-12-10 23:12:54 +01:00
|
|
|
- Eugene Christensen
|
2007-11-27 06:02:50 +01:00
|
|
|
- Fabrice Fontaine
|
2007-01-09 02:18:28 +01:00
|
|
|
- Fredrik Svensson
|
2007-04-28 20:42:14 +02:00
|
|
|
- Glen Masgai
|
2010-11-07 12:45:05 +01:00
|
|
|
- Hartmut Holzgraefe (hholzgra)
|
2011-03-10 20:21:25 +01:00
|
|
|
- Iain Denniston (ectotropic)
|
2008-01-22 11:39:59 +01:00
|
|
|
- Ingo Hofmann
|
2010-12-18 22:29:24 +01:00
|
|
|
- Ivan Romanov (ivanromanov)
|
2006-07-07 09:16:58 +02:00
|
|
|
- Jiri Zouhar
|
2006-12-23 21:37:46 +01:00
|
|
|
- John Dennis
|
2007-12-24 22:21:48 +01:00
|
|
|
- Jonathan Casiot (no_dice)
|
2007-12-17 02:15:53 +01:00
|
|
|
- Josh Carroll
|
Two fixes from Juergen Lock <nox(at)jelal.kn-bremen.de>:
1. varargs: pass size of CRLF as size_t not as int:
--- upnp/src/gena/gena_device.c.orig
+++ upnp/src/gena/gena_device.c
@@ -225,7 +225,7 @@ static UPNP_INLINE int notify_send_and_r
"bbb",
start_msg.buf, start_msg.length,
propertySet, strlen(propertySet),
- "\r\n", 2);
+ "\r\n", sizeof "\r\n" - 1);
if (ret_code) {
membuffer_destroy(&start_msg);
sock_destroy(&info, SD_BOTH);
2. Remove "b" arg here, there is no buffer passed: (this caused a pointer
to be interpreted as a buffer size to be alloc'd/copied, hence the 32 GB.)
--- upnp/src/genlib/net/http/webserver.c.orig
+++ upnp/src/genlib/net/http/webserver.c
@@ -1262,7 +1262,7 @@ static int process_request(
// Content-Range: bytes 222-3333/4000 HTTP_PARTIAL_CONTENT
// Transfer-Encoding: chunked
if (http_MakeMessage(headers, resp_major, resp_minor,
- "R" "TLD" "s" "tcS" "b" "Xc" "sCc",
+ "R" "TLD" "s" "tcS" "Xc" "sCc",
HTTP_OK, // status code
finfo.content_type, // content type
RespInstr, // language info
(cherry picked from commit ed0ebe15883a46dd4ad885cce77db467db68306f)
2010-11-23 02:27:20 +01:00
|
|
|
- Juergen Lock
|
2007-08-06 07:11:07 +02:00
|
|
|
- Keith Brindley
|
2006-12-23 21:37:46 +01:00
|
|
|
- Leuk_He
|
2006-07-08 15:16:18 +02:00
|
|
|
- Loigu
|
2008-03-09 02:16:58 +01:00
|
|
|
- Luke Kim (nereusuj)
|
2007-11-06 03:29:03 +01:00
|
|
|
- Marcelo Roberto Jimenez (mroberto)
|
2006-07-08 15:16:18 +02:00
|
|
|
- Markus Strobl
|
2007-12-24 22:21:48 +01:00
|
|
|
- Nektarios K. Papadopoulos (npapadop)
|
2008-06-27 13:38:03 +02:00
|
|
|
- Nicholas Kraft
|
2008-07-24 13:29:47 +02:00
|
|
|
- Nick Leverton (leveret)
|
2010-11-07 12:45:05 +01:00
|
|
|
- Obata Akio (obache)
|
2006-12-23 21:37:46 +01:00
|
|
|
- Oskar Liljeblad
|
2007-12-24 22:21:48 +01:00
|
|
|
- Michael (oxygenic)
|
2006-12-23 21:37:46 +01:00
|
|
|
- Paul Vixie
|
2008-01-22 00:35:08 +01:00
|
|
|
- Peter Hartley
|
2007-06-09 15:40:22 +02:00
|
|
|
- Rene Hexel
|
2007-12-24 22:21:48 +01:00
|
|
|
- Robert Gingher (robsbox)
|
2010-08-19 15:39:44 +02:00
|
|
|
- Ronan Menard
|
2006-07-07 09:16:58 +02:00
|
|
|
- Siva Chandran
|
2010-11-07 22:20:03 +01:00
|
|
|
- Stefan Sommerfeld (zerocom)
|
2007-08-06 04:07:41 +02:00
|
|
|
- Stéphane Corthésy
|
2007-11-12 04:27:58 +01:00
|
|
|
- Steve Bresson
|
2007-04-28 20:42:14 +02:00
|
|
|
- Timothy Redaelli
|
2007-05-26 05:56:25 +02:00
|
|
|
- Titus Winters
|
2011-01-17 14:36:52 +01:00
|
|
|
- Tom (tomdev2)
|
2006-07-07 09:16:58 +02:00
|
|
|
|