From fdb529bd0613308591352ac1d4e765c4d33710c9 Mon Sep 17 00:00:00 2001
From: jedav <jedavis.alephnull@gmail.com>
Date: Mon, 9 Sep 2024 19:53:56 -0700
Subject: [PATCH] Move removeIndex's result instead of copying (#1516)

Currently removeIndex copies the removed value into removed and then
destructs the original, which can cause significant performance overhead.

Co-authored-by: Jordan Bayles <bayles.jordan@gmail.com>
---
 src/lib_json/json_value.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
index 26cd843..a5e2dd8 100644
--- a/src/lib_json/json_value.cpp
+++ b/src/lib_json/json_value.cpp
@@ -1205,7 +1205,7 @@ bool Value::removeIndex(ArrayIndex index, Value* removed) {
     return false;
   }
   if (removed)
-    *removed = it->second;
+    *removed = std::move(it->second);
   ArrayIndex oldSize = size();
   // shift left all items left, into the place of the "removed"
   for (ArrayIndex i = index; i < (oldSize - 1); ++i) {