generic-library/jsoncpp
1
0
Fork 0
mirror of https://github.com/open-source-parsers/jsoncpp.git synced 2025-01-06 00:31:10 +01:00
Code Issues Projects Releases Wiki Activity

fix Reader bug and add testcase (#1122)

Browse Source
This commit is contained in:
Chen 2019-12-23 10:56:54 +08:00 committed by GitHub
parent d6c4a8fb2d
commit 92d90250f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib_json/json_reader.cpp
View File

@ -467,7 +467,7 @@ bool Reader::readObject(Token& token) {
Value numberName; Value numberName;
if (!decodeNumber(tokenName, numberName)) if (!decodeNumber(tokenName, numberName))
return recoverFromError(tokenObjectEnd); return recoverFromError(tokenObjectEnd);
name = String(numberName.asCString()); name = numberName.asString();
} else { } else {
break; break;
} }

11
src/test_lib_json/main.cpp
View File

@ -2648,6 +2648,10 @@ struct ReaderTest : JsonTest::TestCase {
new Json::Reader(Json::Features{}.strictMode())); new Json::Reader(Json::Features{}.strictMode()));
} }
void setFeatures(Json::Features& features) {
reader = std::unique_ptr<Json::Reader>(new Json::Reader(features));
}
void checkStructuredErrors( void checkStructuredErrors(
const std::vector<Json::Reader::StructuredError>& actual, const std::vector<Json::Reader::StructuredError>& actual,
const std::vector<Json::Reader::StructuredError>& expected) { const std::vector<Json::Reader::StructuredError>& expected) {
@ -2851,6 +2855,13 @@ JSONTEST_FIXTURE_LOCAL(ReaderTest, pushErrorTest) {
"See Line 1, Column 14 for detail.\n"); "See Line 1, Column 14 for detail.\n");
} }
JSONTEST_FIXTURE_LOCAL(ReaderTest, allowNumericKeysTest) {
Json::Features features;
features.allowNumericKeys_ = true;
setFeatures(features);
checkParse(R"({ 123 : "abc" })");
}
struct CharReaderTest : JsonTest::TestCase {}; struct CharReaderTest : JsonTest::TestCase {};
JSONTEST_FIXTURE_LOCAL(CharReaderTest, parseWithNoErrors) { JSONTEST_FIXTURE_LOCAL(CharReaderTest, parseWithNoErrors) {