From 7d82b1472674c5ed3907d65789811ca04ac25d5b Mon Sep 17 00:00:00 2001 From: Christopher Dunn Date: Sat, 24 Jan 2015 14:34:54 -0600 Subject: [PATCH] fix issue #90 We are static-casting to U, so we really have no reason to use references. However, if this comes up again, try applying -ffloat-store to the target executable, per https://github.com/open-source-parsers/jsoncpp/issues/90 --- src/test_lib_json/CMakeLists.txt | 3 +++ src/test_lib_json/jsontest.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/test_lib_json/CMakeLists.txt b/src/test_lib_json/CMakeLists.txt index 420d659..24dc56f 100644 --- a/src/test_lib_json/CMakeLists.txt +++ b/src/test_lib_json/CMakeLists.txt @@ -11,6 +11,9 @@ ADD_EXECUTABLE( jsoncpp_test TARGET_LINK_LIBRARIES(jsoncpp_test jsoncpp_lib) +# another way to solve issue #90 +#set_target_properties(jsoncpp_test PROPERTIES COMPILE_FLAGS -ffloat-store) + # Run unit tests in post-build # (default cmake workflow hides away the test result into a file, resulting in poor dev workflow?!?) IF(JSONCPP_WITH_POST_BUILD_UNITTEST) diff --git a/src/test_lib_json/jsontest.h b/src/test_lib_json/jsontest.h index cf1ef6b..127b7c2 100644 --- a/src/test_lib_json/jsontest.h +++ b/src/test_lib_json/jsontest.h @@ -178,8 +178,8 @@ private: template TestResult& checkEqual(TestResult& result, - const T& expected, - const U& actual, + T expected, + U actual, const char* file, unsigned int line, const char* expr) {