generic-library/isa-l
1
0
Fork 0
mirror of https://github.com/intel/isa-l.git synced 2024-12-12 09:23:50 +01:00
Code Issues Projects Releases Wiki Activity

igzip: cleanup perf test related code

Browse Source 
This patch addresses some cppcheck issues.
And some minor changes to maintain code consistency.

- Cleanup cppcheck issues.
  [log][igzip/igzip_perf.c] (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
  [log][igzip/igzip_hist_perf.c:132]: (error) Memory leak: outbuf

- Some minor changes to maintain code consistency.
  igzip/igzip_build_hash_table_perf.c
  igzip/igzip_hist_perf.c
  igzip/igzip_semi_dyn_file_perf.c

- delete unused variable
  outbuf and outbuf_size from igzip/igzip_hist_perf.c

Change-Id: Icbbd8f70de689931c8a844d89e457af8d97c6793
Signed-off-by: Zhiyuan Zhu <zhiyuan.zhu@arm.com>
This commit is contained in:
Zhiyuan Zhu 2019-12-04 17:14:21 +08:00
parent 683364c47b
commit f430953f0a
4 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
igzip/igzip_build_hash_table_perf.c
View File

@ -31,8 +31,7 @@ int main(int argc, char *argv[])
struct perf start;
BENCHMARK(&start, time, isal_deflate_hash(&stream, dict, dict_len));
printf("igzip_build_hash_table_perf:\n");
printf(" in_size=%u ", dict_len);
printf("igzip_build_hash_table_perf: in_size=%u ", dict_len);
perf_print(start, (long long)dict_len);
return 0;

16
igzip/igzip_hist_perf.c
View File

@ -68,9 +68,9 @@ void print_histogram(struct isal_huff_histogram *histogram)
int main(int argc, char *argv[])
{
FILE *in;
unsigned char *inbuf, *outbuf;
unsigned char *inbuf;
int iterations, avail_in;
uint64_t infile_size, outbuf_size;
uint64_t infile_size;
struct isal_huff_histogram histogram1, histogram2;
memset(&histogram1, 0, sizeof(histogram1));
@ -92,7 +92,6 @@ int main(int argc, char *argv[])
* (assuming some possible expansion on output size)
*/
infile_size = get_filesize(in);
outbuf_size = 2 * infile_size;
if (infile_size != 0)
iterations = RUN_MEM_SIZE / infile_size;
@ -103,19 +102,14 @@ int main(int argc, char *argv[])
iterations = MIN_TEST_LOOPS;
inbuf = malloc(infile_size);
outbuf = malloc(outbuf_size);
if (inbuf == NULL) {
fprintf(stderr, "Can't allocate input buffer memory\n");
exit(0);
}
if (outbuf == NULL) {
fprintf(stderr, "Can't allocate output buffer memory\n");
exit(0);
}
avail_in = fread(inbuf, 1, infile_size, in);
if (avail_in != infile_size) {
free(inbuf);
fprintf(stderr, "Couldn't fit all of input file into buffer\n");
exit(0);
}
@ -124,10 +118,12 @@ int main(int argc, char *argv[])
BENCHMARK(&start, BENCHMARK_TIME,
isal_update_histogram(inbuf, infile_size, &histogram1));
printf(" file %s - in_size=%lu\n", argv[1], infile_size);
printf("igzip_file: ");
printf("igzip_hist_file: ");
perf_print(start, (long long)infile_size);
fclose(in);
fflush(0);
free(inbuf);
return 0;
}

2
igzip/igzip_perf.c
View File

@ -51,7 +51,7 @@
/* Limit output buffer size to 2 Gigabytes. Since stream->avail_out is a
* uint32_t and there is no logic for handling an overflowed output buffer in
* the perf test, this define must be less then 4 Gigabytes */
#define MAX_COMPRESS_BUF_SIZE (1 << 31)
#define MAX_COMPRESS_BUF_SIZE (1U << 31)
int level_size_buf[10] = {
#ifdef ISAL_DEF_LVL0_DEFAULT

2
igzip/igzip_semi_dyn_file_perf.c
View File

@ -288,7 +288,7 @@ int main(int argc, char *argv[])
printf(" file %s - in_size=%lu out_size=%d iter=%d ratio=%3.1f%%\n", argv[optind],
infile_size, stream.total_out, i, 100.0 * stream.total_out / infile_size);
printf("igzip_file: ");
printf("igzip_semi_dyn_file: ");
perf_print(start, (long long)infile_size);
if (out != NULL) {