From bc32a874522a3b1631b664952a9887d45d44b573 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Fri, 12 Feb 2021 12:19:16 -0500 Subject: [PATCH] Googletest export Update the custom name example to not use underscores. The NOTE a few blocks above specifically calls out that test names should not contain undersccores, so probably the example should not suggest using underscores. PiperOrigin-RevId: 357204578 --- docs/advanced.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/advanced.md b/docs/advanced.md index 9b3cf5ac..49f7f541 100644 --- a/docs/advanced.md +++ b/docs/advanced.md @@ -1489,12 +1489,12 @@ INSTANTIATE_TEST_SUITE_P( MyGroup, MyTestSuite, testing::Combine( testing::Values(MyType::VALUE_0, MyType::VALUE_1), - testing::ValuesIn("", "")), + testing::Values("A", "B")), [](const testing::TestParamInfo& info) { std::string name = absl::StrCat( - std::get<0>(info.param) == MY_FOO ? "Foo" : "Bar", "_", + std::get<0>(info.param) == MY_FOO ? "Foo" : "Bar", std::get<1>(info.param)); - absl::c_replace_if(name, [](char c) { return !std::isalnum(c); }, '_'); + absl::c_replace_if(name, [](char c) { return !std::isalnum(c); }, ''); return name; }); ```