Merge branch 'master' into issue_1735

This commit is contained in:
Gennadiy Civil 2018-08-24 11:30:02 -04:00 committed by GitHub
commit 205df1058e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2679,18 +2679,18 @@ void TestInfo::Run() {
factory_, &internal::TestFactoryBase::CreateTest, factory_, &internal::TestFactoryBase::CreateTest,
"the test fixture's constructor"); "the test fixture's constructor");
// Runs the test only if the test object was created and its // Runs the test if the constructor didn't generate a fatal failure.
// constructor didn't generate a fatal failure. // Note that the object will not be null
if ((test != NULL) && !Test::HasFatalFailure()) { if (!Test::HasFatalFailure()) {
// This doesn't throw as all user code that can throw are wrapped into // This doesn't throw as all user code that can throw are wrapped into
// exception handling code. // exception handling code.
test->Run(); test->Run();
} }
// Deletes the test object. // Deletes the test object.
impl->os_stack_trace_getter()->UponLeavingGTest(); impl->os_stack_trace_getter()->UponLeavingGTest();
internal::HandleExceptionsInMethodIfSupported( internal::HandleExceptionsInMethodIfSupported(
test, &Test::DeleteSelf_, "the test fixture's destructor"); test, &Test::DeleteSelf_, "the test fixture's destructor");
result_.set_elapsed_time(internal::GetTimeInMillis() - start); result_.set_elapsed_time(internal::GetTimeInMillis() - start);