Commit Graph

140 Commits

Author SHA1 Message Date
Alvin
2fca06ff6d
Fix compiler warnings and condition check improvements (#390)
* fix compiler warnings

- loglevels.cpp - warns about double return if dynamic logging is on

- crash handler_unix.cpp - warns about unused variable
2020-11-23 21:23:13 -07:00
Alvin
c0ae589024
Alvin/minor fixes and improvements (#389)
* Fix typos
* Fix build for MinGW
- MinGW g++ doesn't recoganize `-rdynamic`
2020-11-17 20:40:26 -07:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
a4abb8b521
Update loglevels.hpp 2020-08-07 10:22:18 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
c2b1ff6475
Update loglevels.hpp 2020-08-05 12:30:09 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
e55c270753
Update loglevels.hpp 2020-08-05 12:28:17 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
b93e96ebf7
Update loglevels.hpp 2020-08-05 12:27:05 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
69a0be4c9c
play/tryout: It is confusing to name the target g3logger. KISS --> g3log (#372)
* It is confusing to name the target g3logger. KISS --> g3log. This MIGHT break installations for some but it's a needed correction. 

* Updated version number to 2.1.x
2020-07-08 22:42:55 -06:00
shiyuge
8e79dd6554
bug fix: vsnprintf_s return value 0 isn't error (#373)
Conforming with vsnprintf_s
2020-07-06 21:21:28 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
cdceb28deb
Update logworker.hpp (#369) 2020-06-29 11:58:01 -06:00
shiyuge
e639f6d800
fix typo in logworker.hpp (#365) 2020-06-24 07:31:26 -06:00
shiyuge
2206cea309
fix typo in shared_queue.hpp exampel -> example (#363) 2020-06-23 06:53:33 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
5ef196eed5
Manual addition of sink removal functionality from C++11 branch (#361)
* Added sink removal
* improved build script
2020-06-19 13:49:30 -06:00
Roman Popov
751330bb41
Allow throwing from exit handler (#349)
For example for unit testing purposes we may want to replace SIGABRT with
throwing an exception, so that unit tests for CHECK()s can be written.
2020-05-08 20:13:25 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
aab25a4091
one more comment fix 2020-05-08 14:33:50 -06:00
Kjell Hedström : Available for new Engineering Leadership and Engineering Opportunities
62162e8613
updated code comments since SIGABRT is used with default fatal handler instead of a throw 2020-05-08 14:30:52 -06:00
JoelStienlet
4000c5c899
remove std::move in return : std::future can only be moved anyway (#336)
Co-authored-by: Joel Stienlet <stienlet@localhost.localdomain>
2020-03-06 07:55:36 -07:00
Nicholas Lederer
9fb3e61e89
fix issue with stacktrace_windows not allocating sufficient memory for SYMBOL_INFO struct (#334) 2020-02-25 07:15:09 -07:00
Paul Smith
f149179178 Ensure LOG* and CHECK* macros are statement-safe (#320)
The LOG and LOGF macros had been modified to be statement-safe, but the
LOG_IF, CHECK, LOGF_IF, CHECKF, and CHECK_F macros were all still
unsafe in face of code where single-statement blocks were not enclosed
in {}.

For example code like this:

  if (!foobar)
      CHECKF(goodness, "badness detected!");
  else
      handle_foobar(foobar);

would fail in subtle and possibly dangerous ways.

Fix this by combining multiple if-statements into a single conditional
and inverting the conditions, then adding an empty then-block and moving
the log statement to the else-block.
2019-07-28 16:07:16 -06:00
Aleksey Dobrunov
1a010de2f6 Mingw parse error (#293)
* fix 'Failure to successfully parse the message' on mingw

* removed redundant checks
2019-01-15 12:27:53 -07:00
Christos
cf36852238 Wrap gnu::format around #if to avoid msvc warnings (#291)
* Wrap gnu::format around #if to avoid msvc warnings

* Fix compilation issue
2018-12-17 20:08:02 -07:00
Nils Gladitz
048b23d38c Use C++11 generic attribute syntax to avoid issue #282 (#283) 2018-11-19 15:25:14 -07:00
ccvca
39526ce9d2 Fix: VS 2015 logmessage.cpp(167): error C2437: "_file" already initialized (#277) 2018-07-13 05:59:11 -06:00
outkontroll
a6788f89be VS2013 missing include (#273) 2018-06-21 15:39:26 -06:00
Andreas Schönle
7b0414f76f Use defective stlpatch_future.hpp only for VS2013 (#266) 2018-05-14 06:43:05 -06:00
John Farrier
69f21e3513 Fixed ambiguous constructor error. (#262) 2018-04-26 20:30:26 -06:00
DerekJuba-NIST
7f25b004cf Update loglevels.hpp (#259)
Fixed typo DEBUG -> DBUG
2018-04-12 09:55:42 -06:00
Jeff Ebert
408061280f restore original sigaction in restoreSignalHandler (#254)
* restore original sigaction in restoreSignalHandler

- Save original sigactions in a map called gSavedSigActions
- In restoreSignalHandler, do nothing if there is no saved sigaction.
  If there is a saved sigaction, then re-install it.
- Fixes issue #253

* fix bug found in code review of PR #254

* add functions for reporting sigaction errors

- Factor out reportSigactionError functions from functions that
  call sigaction to allow unit testing.
- Use strsignal libc function to convert from signal number to name
  to eliminate chance of not finding the name in {g,k}Signals maps.

* cleanup. perror doesn't need a wrapper. put code under test
2018-03-25 21:43:49 -06:00
Kjell Hedström
14db37ad23
G3log placeholder thread ID formatting (#248)
* Added thread ID configurable through API calls. Left to do g3sinks, documentation and some corner test cases for CHECK, LOG(FATAL) and FATAL signal

* improve test script, break if error

* easier to use API. Api docs added

* Update API.markdown

* Update API.markdown

* Update API.markdown

* updated readme with details for overriding default for "full details"

* updated custom sink with custom formatting example
2018-03-08 09:16:12 -07:00
Kjell Hedström
f2b860a2b4
Addressing the std2 concern raised in https://github.com/KjellKod/g3log/issues/212 (#246) 2018-02-20 22:02:19 -07:00
maj-tom
0ddfd6dccc Fix dangling else in LOG and LOGF macros (#231)
* Fix dangling else in LOG and LOGF macros
Closes #224

* added unit test
2017-12-06 21:31:55 -07:00
PeasantCodeFarmer
e7d3b9d7b1 Comment change for issue #232 (#237)
* Fixing some English/typos and a cyclical header include.

* Comment fix for issue# 232
2017-12-04 18:24:55 -07:00
PeasantCodeFarmer
b4be5a0f00 Fixing some English/typos and a cyclical header include. (#234) 2017-11-22 07:41:35 -07:00
Matt Patterson
b3cb1ba057 atomicbool.hpp needs EOF outside of comment to build on VS15 (#229) 2017-10-26 18:37:37 -06:00
spinorx
28105e08d7 Support full filenames in logs. (#226)
This is helpful for doing cut and paste of filenames when opening.
Also fixed couple of macro parentheses.
2017-10-11 12:59:46 -06:00
Kjell Hedsröm
96d6cda239 fixed comparison warning 2017-09-23 19:16:51 -06:00
mobileben
93c05406d8 Add in support for configurable kMaxMessageValue #203 (#208)
* Add in support for configurable kMaxMessageValue #203

* Add in documentation for USE_G3_DYNAMIC_MAX_MESSAGE_SIZE
2017-09-08 22:51:46 -06:00
maj-tom
97c6cf45b3 Update filesink.cpp (#216) 2017-07-19 13:16:50 -06:00
Andreas Schönle
f42611d2a1 fixed windows timestamp (#200)
* fixed windows timestamp

* ficing linux time

* Fix to_system_time

* fix last review issue.

* fixed formatting.

* Comment added to to_system_time() functiuon.:wq
2017-06-04 07:47:29 -06:00
Kjell Hedström
c08fba999b Definitions made explicit (#196)
* force definition inclusion

* to make it clear to the user
2017-05-17 08:25:29 -06:00
Jakob Wanner
24dea1ceea Cast char array to pointer to char in INTERNAL_LOG_MESSAGE (#193) 2017-05-17 08:07:39 -06:00
Andreas Schönle
123977f106 unit tests running with windows shared dll (#178)
* unit tests running with windows shared dll

* CMake automatically uses DLL runtime - remove cmake entries modifying
compiler flags

* missing DBUG vs DEBUG issue in Linux

* generated header added

* correction in CMake: Set HEADER_FILES correctly

* added static library option

* switched to powershell and included WORKING_DIRECTORY

* powershell use in windows and WORKING_DIRECTORY instead of cd

* Fixed appveyor.yml to use Release configuration and run unit tests

* trying to make appveyor work again ...

* make sure ERRORLEVEL is 0 when unit tests run successfully

* Still trying to fix appveyor ...

* Defaulting to shared library in linux, too

* Removed runtime loading test when g3log is not a shared library in linux

* Run unit tests verbosly using ctest.exe

* Disabled AggressiveThreadCallsDuringShutdown test

* Revert "Run unit tests verbosly using ctest.exe" (accidental commit)

This reverts commit b30513450d.

* re-committing valid parts of reverted commit

* DBUG vs DEBUG fix moved to generated_definitions.hpp

* cleanup shared/static option

* clarify cmake build types regardless of type

* Added compile test for DEBUG and DBUG

* put back formatting

* Removed commented out /MD switches for MSVC
2017-05-09 10:26:48 -06:00
Kjell Hedström
887673f4d0 Time adjustments for VMs and 32-bit embedded (#177)
* in progress. now using std::chrono

* in progress, not working but defined how to fix it - broken unit tests

* working - verified on VM. Unit tests not yet updated accordintly

* fixed all tests

* fixed formatting

* adjusted timezone during testing

* adjusted test for timezone
2017-04-27 22:57:04 -06:00
Kjell Hedström
121bb9c790 fix OSX/Clang build warnings and 32-bit linking errors regarding build versin (#176) 2017-04-24 21:50:35 -06:00
Kjell Hedström
e04681ac42 Levels api changes 2 (#170)
* in progress

* Update loglevels.hpp

* Update loglevels.hpp

* don't code when too tired

* revert back

* removed comment
2017-04-05 23:03:55 -06:00
Kjell Hedström
33ed100f91 Colorer build and loglevel improvements (#161)
* static build with MS libs; remove vc11 support from cmake
* support AMD processor on winXp
* mingw build
* support older versions
* removed cmake warnings

* fix cmake >= 3.1 warnings (CMP0054)
* add target_include_directories - in projects that depend on g3log, do not need to specify include_directories
* Improved CPackage installation
* cleanup of build and test scripts
* c++14 gives for cleaner syntax
* build cleanup libg3logger.so will be a link to the actual libg3logger.so.<major><minor><build>. Only shared libraries from now on



* disableAll for log levels
* new setLogLevel impl
* cleaned up levels, now it should be easy for the user to understand how to add custom levels
2017-03-30 22:52:09 -06:00
Kjell Hedström
6e77118706 Time correction (#159)
* Improved the cpackage build. Also removed test compilation warnings

* To correcte what was reported in issue 155 (https://github.com/KjellKod/g3log/issues/155)
2017-03-28 11:09:10 -06:00
Kjell Hedström
c71349ac3d Update time.cpp 2017-01-08 14:01:38 -07:00
Kjell Hedström
a04b17abb5 Merge pull request #144 from rickyzhang82/pr-fix-output-format
Fix message newline issue
2016-12-23 09:13:19 -07:00
Ricky Zhang
d747de2840
Add back ugly tab
Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>
2016-12-22 19:33:29 -05:00
Ricky Zhang
fc615b4ac0
Fix message newline issue
Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>
2016-12-22 11:23:25 -05:00