mirror of
https://github.com/KjellKod/g3log.git
synced 2024-12-13 10:42:56 +01:00
Pull request template is improved
This commit is contained in:
parent
6d0eb32ddb
commit
7f3159e17f
@ -1,4 +1,14 @@
|
||||
* Follow TDD practice.
|
||||
* All new and modified functionality should be backed up with unit tests.
|
||||
* All new functionality should be backed up with API documentation (API.markdown or README.markdown)
|
||||
* Windows, Ubuntu, OSX support must work. Please use local environment + the CI to verify this.
|
||||
- [ ] Follow TDD practice. (new/modified code must be backed down with unit test - preferably TDD style development)
|
||||
- [ ] All new/modified functionality should be backed up with API documentation (API.markdown or README.markdown)
|
||||
- [ ] Cross Platform validation: Wcindows, Ubuntu, OSX support must work. Please use the CI to verify this. If possible using a local environment or VM during development can speed up your iterations.
|
||||
|
||||
|
||||
**Testing Advice**
|
||||
```bash
|
||||
mkdir build; cd build; cmake -DADD_G3LOG_UNIT_TEST=ON ..
|
||||
```
|
||||
|
||||
**Run Test Alternatives:**
|
||||
- Cross-Platform: `ctest`
|
||||
- or `ctest -V` for verbose output
|
||||
- Linux: `make test`
|
||||
|
Loading…
Reference in New Issue
Block a user