generic-library/g3log
1
0
Fork 0
mirror of https://github.com/KjellKod/g3log.git synced 2024-12-12 18:30:25 +01:00
Code Issues Projects Releases Wiki Activity

optionable to buffer x messages before writing to file, default to 100 which will really boost performance (#471)

Browse Source
This commit is contained in:
Kjell Hedström 2022-12-08 22:08:28 -07:00 committed by GitHub
parent dbd3d74a39
commit 6c6122fafc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/filesink.cpp
View File

@ -14,13 +14,15 @@
namespace g3 { namespace g3 {
using namespace internal; using namespace internal;
FileSink::FileSink(const std::string &log_prefix, const std::string &log_directory, const std::string& logger_id) FileSink::FileSink(const std::string &log_prefix, const std::string &log_directory, const std::string& logger_id, size_t write_to_log_every_x_message)
: _log_details_func(&LogMessage::DefaultLogDetailsToString) : _log_details_func(&LogMessage::DefaultLogDetailsToString)
,_log_file_with_path(log_directory) ,_log_file_with_path(log_directory)
, _log_prefix_backup(log_prefix) , _log_prefix_backup(log_prefix)
, _outptr(new std::ofstream) , _outptr(new std::ofstream)
, _header("\t\tLOG format: [YYYY/MM/DD hh:mm:ss uuu* LEVEL FILE->FUNCTION:LINE] message\n\n\t\t(uuu*: microseconds fractions of the seconds value)\n\n") , _header("\t\tLOG format: [YYYY/MM/DD hh:mm:ss uuu* LEVEL FILE->FUNCTION:LINE] message\n\n\t\t(uuu*: microseconds fractions of the seconds value)\n\n")
, _firstEntry(true) , _firstEntry(true)
, _write_counter(0)
, _write_to_log_every_x_message(write_to_log_every_x_message)
{ {
_log_prefix_backup = prefixSanityFix(log_prefix); _log_prefix_backup = prefixSanityFix(log_prefix);
if (!isValidFilename(_log_prefix_backup)) { if (!isValidFilename(_log_prefix_backup)) {
@ -42,10 +44,12 @@ namespace g3 {
FileSink::~FileSink() { FileSink::~FileSink() {
std::string exit_msg {"g3log g3FileSink shutdown at: "}; std::string exit_msg = {"g3log g3FileSink shutdown at: "};
auto now = std::chrono::system_clock::now(); auto now = std::chrono::system_clock::now();
exit_msg.append(localtime_formatted(now, internal::time_formatted)).append("\n"); exit_msg.append(localtime_formatted(now, internal::time_formatted)).append("\n");
filestream() << exit_msg << std::flush;
// write anything buffered up and then end with the exit msg
filestream() << _write_buffer << exit_msg << std::flush;
exit_msg.append("Log file at: [").append(_log_file_with_path).append("]\n"); exit_msg.append("Log file at: [").append(_log_file_with_path).append("]\n");
std::cerr << exit_msg << std::flush; std::cerr << exit_msg << std::flush;
@ -59,7 +63,13 @@ namespace g3 {
} }
std::ofstream &out(filestream()); std::ofstream &out(filestream());
auto data = message.get().toString(_log_details_func);
_write_buffer.append(data);
if (++_write_counter % _write_to_log_every_x_message == 0) {
out << message.get().toString(_log_details_func) << std::flush; out << message.get().toString(_log_details_func) << std::flush;
_write_buffer.clear();
}
} }
std::string FileSink::changeLogFile(const std::string &directory, const std::string &logger_id) { std::string FileSink::changeLogFile(const std::string &directory, const std::string &logger_id) {

6
src/g3log/filesink.hpp
View File

@ -15,7 +15,7 @@ namespace g3 {
class FileSink { class FileSink {
public: public:
FileSink(const std::string &log_prefix, const std::string &log_directory, const std::string &logger_id="g3log"); FileSink(const std::string &log_prefix, const std::string &log_directory, const std::string &logger_id="g3log", size_t write_to_log_every_x_message = 100);
virtual ~FileSink(); virtual ~FileSink();
void fileWrite(LogMessageMover message); void fileWrite(LogMessageMover message);
@ -27,12 +27,14 @@ namespace g3 {
private: private:
LogMessage::LogDetailsFunc _log_details_func; LogMessage::LogDetailsFunc _log_details_func;
std::string _log_file_with_path; std::string _log_file_with_path;
std::string _log_prefix_backup; // needed in case of future log file changes of directory std::string _log_prefix_backup; // needed in case of future log file changes of directory
std::unique_ptr<std::ofstream> _outptr; std::unique_ptr<std::ofstream> _outptr;
std::string _header; std::string _header;
bool _firstEntry; bool _firstEntry;
std::string _write_buffer;
size_t _write_counter;
size_t _write_to_log_every_x_message;
void addLogFileHeader(); void addLogFileHeader();
std::ofstream &filestream() { std::ofstream &filestream() {