ffmpeg/libavformat
Ico Doornekamp a286f1a5ff avformat/rtpdec_jpeg: fix low contrast image on low quality setting
Original mail and my own followup on ffmpeg-user earlier today:

I have a device sending out a MJPEG/RTP stream on a low quality setting.
Decoding and displaying the video with libavformat results in a washed
out, low contrast, greyish image. Playing the same stream with VLC results
in proper color representation.

Screenshots for comparison:

  http://zevv.nl/div/libav/shot-ffplay.jpg
  http://zevv.nl/div/libav/shot-vlc.jpg

A pcap capture of a few seconds of video and SDP file for playing the
stream are available at

  http://zevv.nl/div/libav/mjpeg.pcap
  http://zevv.nl/div/libav/mjpeg.sdp

I believe the problem might be in the calculation of the quantization
tables in the function create_default_qtables(), the attached patch
solves the issue for me.

The problem is that the argument 'q' is of the type uint8_t. According to the
JPEG standard, if 1 <= q <= 50, the scale factor 'S' should be 5000 / Q.
Because the create_default_qtables() reuses the variable 'q' to store the
result of this calculation, for small values of q < 19, q wil subsequently
overflow and give wrong results in the calculated quantization tables. The
patch below uses a new variable 'S' (same name as in RFC2435) with the proper
range to store the result of the division.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e3e6a2cff4af9542455d416faec4584d5e823d5d)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
2016-04-27 04:40:11 +02:00
..
2013-10-13 20:13:38 +00:00
2013-10-18 19:53:47 +02:00
2015-08-21 04:24:58 +00:00
2015-04-07 22:50:07 +02:00
2016-01-15 12:30:40 +01:00
2016-01-28 15:53:54 +01:00
2015-08-18 10:24:01 -04:00
2013-10-06 19:36:53 +02:00
2016-01-27 23:45:44 +01:00
2014-08-30 15:50:22 +00:00
2015-02-26 02:06:10 +01:00
2014-06-18 14:55:28 +02:00
2015-09-03 12:42:40 +02:00
2015-06-14 15:09:33 +02:00
2015-08-20 12:22:50 +02:00
2016-01-15 15:49:35 +01:00
2014-04-16 19:41:41 +02:00
2014-08-24 11:05:42 +00:00
2016-01-28 15:53:54 +01:00
2015-05-26 19:54:41 +02:00
2016-01-15 12:30:40 +01:00
2014-07-13 19:18:31 +02:00
2014-07-13 19:18:31 +02:00
2014-08-15 22:47:45 +02:00
2015-08-21 04:24:58 +00:00
2015-09-01 22:46:23 +02:00
2013-11-13 22:56:18 +01:00
2015-12-20 13:39:45 +01:00
2014-12-18 23:27:07 +01:00
2014-08-24 11:05:42 +00:00
2015-12-06 02:51:27 +01:00
2015-06-07 21:55:46 +02:00
2014-12-20 00:17:43 +01:00
2015-09-01 13:35:37 +02:00
2015-05-27 21:48:47 +02:00
2014-10-21 03:52:27 +02:00
2015-04-23 12:56:31 +02:00
2014-09-30 20:21:14 +02:00
2014-10-22 23:12:38 +02:00
2014-03-08 12:36:57 +01:00
2015-12-13 10:14:24 +01:00
2015-06-22 10:47:29 +03:00
2015-01-11 00:35:01 +01:00
2015-01-11 00:35:01 +01:00
2014-08-24 11:05:42 +00:00
2015-04-24 03:43:56 +02:00