generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rtmpproto: avoid setting auth var value if null

Browse Source 
Use default values if parsed variable is found not to
have any value. Avoids crashing at strlen for salt/user
on the auth call afterwards and needless NULL assignments
for the rest (default is already NULL for those).

Should fix Coverity Scan issues #966644 and #966645

Signed-off-by: Reynaldo H. Verdejo Pinochet <r.verdejo@sisa.samsung.com>
This commit is contained in:
Reynaldo H. Verdejo Pinochet
2014-05-16 13:22:21 -04:00
parent 627d3b8b73
commit e83aae2839
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libavformat/rtmpproto.c
View File

@@ -1712,7 +1712,7 @@ static int handle_connect_error(URLContext *s, const char *desc)
char *value = strchr(ptr, '='); char *value = strchr(ptr, '=');
if (next) if (next)
*next++ = '\0'; *next++ = '\0';
if (value) if (value) {
*value++ = '\0'; *value++ = '\0';
if (!strcmp(ptr, "user")) { if (!strcmp(ptr, "user")) {
user = value; user = value;
@@ -1725,6 +1725,9 @@ static int handle_connect_error(URLContext *s, const char *desc)
} else if (!strcmp(ptr, "nonce")) { } else if (!strcmp(ptr, "nonce")) {
nonce = value; nonce = value;
} }
} else {
av_log(s, AV_LOG_WARNING, "Variable %s has NULL value\n", ptr);
}
ptr = next; ptr = next;
} }