generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

CrystalHD: Improve detection of field pair -> two fields content.

Browse Source 
Istvan Sebok provided a sample where field pair -> two fields content
was being misdetected by the existing logic. I added an additional
test to check the input picture type as identified by our h.264
parser.

Signed-off-by: Philip Langdale <philipl@overt.org>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Philip Langdale 2012-05-05 09:58:39 -07:00 committed by Michael Niedermayer
parent 67a316bbda
commit d1ac8e1034
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libavcodec/crystalhd.c
View File

@ -713,11 +713,20 @@ static inline CopyRet copy_frame(AVCodecContext *avctx,
} }
/* /*
* Testing has shown that in all cases where we don't want to return the * The logic here is purely based on empirical testing with samples.
* full frame immediately, VDEC_FLAG_UNKNOWN_SRC is set. * If we need a second field, it could come from a second input packet,
* or it could come from the same field-pair input packet at the current
* field. In the first case, we should return and wait for the next time
* round to get the second field, while in the second case, we should
* ask the decoder for it immediately.
*
* Testing has shown that we are dealing with the fieldpair -> two fields
* case if the VDEC_FLAG_UNKNOWN_SRC is not set or if the input picture
* type was PICT_FRAME (in this second case, the flag might still be set)
*/ */
return priv->need_second_field && return priv->need_second_field &&
!(output->PicInfo.flags & VDEC_FLAG_UNKNOWN_SRC) ? (!(output->PicInfo.flags & VDEC_FLAG_UNKNOWN_SRC) ||
pic_type == PICT_FRAME) ?
RET_COPY_NEXT_FIELD : RET_OK; RET_COPY_NEXT_FIELD : RET_OK;
} }