generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Calls to url_fseek should have their return value checked in

Browse Source 
av_seek_frame_binary, just as they do in av_seek_frame_generic.
Otherwise, function may return success even though url_fseek reported
failure.

Patch by Sean Soria, first.last at gmail

Originally committed as revision 20744 to svn://svn.ffmpeg.org/ffmpeg/trunk
This commit is contained in:
Sean Soria
2009-12-06 00:03:53 +00:00
committed by Daniel Verkamp
parent a4605efdf5
commit b593f7fdef
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libavformat/utils.c
View File

@@ -1311,6 +1311,7 @@ int av_seek_frame_binary(AVFormatContext *s, int stream_index, int64_t target_ts
int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit; int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit;
int64_t ts_min, ts_max, ts; int64_t ts_min, ts_max, ts;
int index; int index;
int64_t ret;
AVStream *st; AVStream *st;
if (stream_index < 0) if (stream_index < 0)
@@ -1363,7 +1364,8 @@ int av_seek_frame_binary(AVFormatContext *s, int stream_index, int64_t target_ts
return -1; return -1;
/* do the seek */ /* do the seek */
url_fseek(s->pb, pos, SEEK_SET); if ((ret = url_fseek(s->pb, pos, SEEK_SET)) < 0)
return ret;
av_update_cur_dts(s, st, ts); av_update_cur_dts(s, st, ts);