generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

avformat/mp3dec: improve junk skipping heuristic

Browse Source 
Commit 2b3e9bbfb529e6bde238aeb511b55ebe461664c8 caused problems for a
certain API user:

https://code.google.com/p/chromium/issues/detail?id=537725
https://code.google.com/p/chromium/issues/detail?id=542032

The problem seems rather arbitrary, because if there's junk, anything
can happen. In this case, the imperfect junk skipping just caused it to
read different junk, from what I can see.

We can improve the accuracy of junk detection by a lot by checking if 2
consecutive frames use the same configuration. While in theory it might
be completely fine for the 1st frame to have a different format than the
2nd frame, it's exceedingly unlikely, and I can't think of a legitimate
use-case.

This is approximately the same mpg123 does for junk skipping. The
set of compared header bits is the same as the libavcodec mp3 parser
uses for similar purposes.
(cherry picked from commit de1b1a7da9e6ddf42447271e519099a88b389e4a)

Conflicts:
	libavformat/mp3dec.c
This commit is contained in:
wm4 2015-10-20 12:17:21 +02:00 committed by Carl Eugen Hoyos
parent 1f25a3ddb8
commit 9362282fd1
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
libavformat/mp3dec.c
View File

@ -42,6 +42,9 @@
#define XING_TOC_COUNT 100 #define XING_TOC_COUNT 100
#define SAME_HEADER_MASK \
(0xffe00000 | (3 << 17) | (3 << 10) | (3 << 19))
typedef struct { typedef struct {
AVClass *class; AVClass *class;
int64_t filesize; int64_t filesize;
@ -54,7 +57,7 @@ typedef struct {
int is_cbr; int is_cbr;
} MP3DecContext; } MP3DecContext;
static int check(AVFormatContext *s, int64_t pos); static int check(AVFormatContext *s, int64_t pos, uint32_t *header);
/* mp3 read */ /* mp3 read */
@ -374,13 +377,22 @@ static int mp3_read_header(AVFormatContext *s)
off = avio_tell(s->pb); off = avio_tell(s->pb);
for (i = 0; i < 64 * 1024; i++) { for (i = 0; i < 64 * 1024; i++) {
uint32_t header, header2;
int frame_size;
if (!(i&1023)) if (!(i&1023))
ffio_ensure_seekback(s->pb, i + 1024 + 4); ffio_ensure_seekback(s->pb, i + 1024 + 4);
if (check(s, off + i) >= 0) { frame_size = check(s, off + i, &header);
av_log(s, AV_LOG_INFO, "Skipping %d bytes of junk at %lld.\n", i, (long long)off); if (frame_size > 0) {
avio_seek(s->pb, off, SEEK_SET);
ffio_ensure_seekback(s->pb, i + 1024 + frame_size + 4);
if (check(s, off + i + frame_size, &header2) >= 0 &&
(header & SAME_HEADER_MASK) == (header2 & SAME_HEADER_MASK))
{
av_log(s, AV_LOG_INFO, "Skipping %d bytes of junk at %"PRId64".\n", i, off);
avio_seek(s->pb, off + i, SEEK_SET); avio_seek(s->pb, off + i, SEEK_SET);
break; break;
} }
}
avio_seek(s->pb, off, SEEK_SET); avio_seek(s->pb, off, SEEK_SET);
} }
@ -425,7 +437,7 @@ static int mp3_read_packet(AVFormatContext *s, AVPacket *pkt)
return ret; return ret;
} }
static int check(AVFormatContext *s, int64_t pos) static int check(AVFormatContext *s, int64_t pos, uint32_t *ret_header)
{ {
int64_t ret = avio_seek(s->pb, pos, SEEK_SET); int64_t ret = avio_seek(s->pb, pos, SEEK_SET);
unsigned header; unsigned header;
@ -437,6 +449,9 @@ static int check(AVFormatContext *s, int64_t pos)
return -1; return -1;
if (avpriv_mpegaudio_decode_header(&sd, header) == 1) if (avpriv_mpegaudio_decode_header(&sd, header) == 1)
return -1; return -1;
if (ret_header)
*ret_header = header;
return sd.frame_size; return sd.frame_size;
} }
@ -490,7 +505,7 @@ static int mp3_seek(AVFormatContext *s, int stream_index, int64_t timestamp,
continue; continue;
for(j=0; j<MIN_VALID; j++) { for(j=0; j<MIN_VALID; j++) {
ret = check(s, pos); ret = check(s, pos, NULL);
if(ret < 0) if(ret < 0)
break; break;
if ((ie->pos - pos)*dir <= 0 && abs(MIN_VALID/2-j) < score) { if ((ie->pos - pos)*dir <= 0 && abs(MIN_VALID/2-j) < score) {