generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

flacdec: simplify bounds checking in flac_probe()

Browse Source 
Simplify `p->buf > p->buf + p->buf_size - 4' as `p->buf_size < 4'.
Avoid a possible out-of-bounds pointer, which is undefined behavior
in C.

CC: libav-stable@libav.org

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
This commit is contained in:
Xi Wang 2013-03-15 07:11:47 -04:00 committed by Luca Barbato
parent eba1ff3130
commit 8425d693ee
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libavformat/flacdec.c
View File

@ -279,11 +279,9 @@ static int flac_read_header(AVFormatContext *s)
static int flac_probe(AVProbeData *p) static int flac_probe(AVProbeData *p)
{ {
uint8_t *bufptr = p->buf; if (p->buf_size < 4 || memcmp(p->buf, "fLaC", 4))
uint8_t *end = p->buf + p->buf_size; return 0;
return AVPROBE_SCORE_MAX/2;
if(bufptr > end-4 || memcmp(bufptr, "fLaC", 4)) return 0;
else return AVPROBE_SCORE_MAX/2;
} }
AVInputFormat ff_flac_demuxer = { AVInputFormat ff_flac_demuxer = {