From 551f683861bbae1002542e70dc196244a1cd24ad Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Thu, 28 Mar 2013 23:59:41 +0100 Subject: [PATCH] yop: Do not keep a copy of parts of the returned packet Fixes double free Regression since the new buffer references, thus no FFmpeg releases should be affected Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavformat/yop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/yop.c b/libavformat/yop.c index d1c01290d6..c84deea58e 100644 --- a/libavformat/yop.c +++ b/libavformat/yop.c @@ -135,8 +135,7 @@ static int yop_read_packet(AVFormatContext *s, AVPacket *pkt) if (yop->video_packet.data) { *pkt = yop->video_packet; - yop->video_packet.data = NULL; - yop->video_packet.size = 0; + memset(&yop->video_packet, 0, sizeof(yop->video_packet)); pkt->data[0] = yop->odd_frame; pkt->flags |= AV_PKT_FLAG_KEY; yop->odd_frame ^= 1;