generic-library/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

imc: sanity check scalefactors.

Browse Source 
This fixes undefined behavior

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer 2012-11-14 00:01:56 +01:00
parent 1f1960519a
commit 2f74f8d7dc
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libavcodec/imc.c
View File

@ -805,6 +805,13 @@ static int imc_decode_block(AVCodecContext *avctx, IMCContext *q, int ch)
imc_decode_level_coefficients2(q, chctx->levlCoeffBuf, chctx->old_floor, imc_decode_level_coefficients2(q, chctx->levlCoeffBuf, chctx->old_floor,
chctx->flcoeffs1, chctx->flcoeffs2); chctx->flcoeffs1, chctx->flcoeffs2);
for(i=0; i<BANDS; i++) {
if(chctx->flcoeffs1[i] > INT_MAX) {
av_log(avctx, AV_LOG_ERROR, "scalefactor out of range\n");
return AVERROR_INVALIDDATA;
}
}
memcpy(chctx->old_floor, chctx->flcoeffs1, 32 * sizeof(float)); memcpy(chctx->old_floor, chctx->flcoeffs1, 32 * sizeof(float));
counter = 0; counter = 0;