generic-library/cxx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Nico Rieck: Currently _MSC_VER and _WIN32 are used to guard code which is

Browse Source 
MSVC-specific, MSVCRT-specific, or Windows-specific. Because Clang can
also define _MSC_VER, and MSVCRT is not necessarily the only C runtime,
these macros should not be used interchangeably.

This patch divides all Windows-related bits into the aforementioned
categories. Two new macros are introduced:

- _LIBCPP_MSVC: Defined when compiling with MSVC. Detected using
  _MSC_VER, excluding Clang.
- _LIBCPP_MSVCRT: Defined when using the Microsoft CRT. This is the default
   when _WIN32 is defined.

This leaves _WIN32 for code using the Windows API.

This also corrects the spelling of _LIBCP_HAS_IS_BASE_OF to _LIBCPP_HAS_IS_BASE_OF.

Nico, please prepare a patch for CREDITS.TXT, thanks.

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@187593 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Howard Hinnant
2013-08-01 18:17:34 +00:00
parent 56dcf0b809
commit e9df0a5c6c
20 changed files with 127 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/support/platform_support.h
View File

@@ -47,7 +47,7 @@ inline
std::string
get_temp_file_name()
{
#ifdef _WIN32
#ifdef _LIBCPP_MSVCRT
char* p = _tempnam( NULL, NULL );
if (p == nullptr)
abort();