diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.algorithm/swap.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.algorithm/swap.pass.cpp index 476ca0c4..4d3a742d 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.algorithm/swap.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.algorithm/swap.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); std::thread::id id0 = t0.get_id(); std::thread t1; std::thread::id id1 = t1.get_id(); diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp index 94a30e74..2db9430a 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp @@ -48,13 +48,16 @@ int main() { assert(G::n_alive == 0); assert(!G::op_run); - std::thread t0(G(), 5, 5.5); + { + G g; + std::thread t0(g, 5, 5.5); std::thread::id id = t0.get_id(); std::thread t1; t1 = std::move(t0); assert(t1.get_id() == id); assert(t0.get_id() == std::thread::id()); t1.join(); + } assert(G::n_alive == 0); assert(G::op_run); } diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp index 8cb2cb17..7198d226 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp @@ -13,6 +13,9 @@ // memory is not freed. This will cause ASAN to fail. // XFAIL: asan +// NOTE: TSAN will report this test as leaking a thread. +// XFAIL: tsan + // // class thread @@ -62,14 +65,13 @@ void f1() int main() { -#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES std::set_terminate(f1); { - std::thread t0(G(), 5, 5.5); + G g; + std::thread t0(g, 5, 5.5); std::thread::id id = t0.get_id(); std::thread t1; t0 = std::move(t1); assert(false); } -#endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES } diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/move.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/move.pass.cpp index 36e0fbd7..e88304ec 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/move.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/move.pass.cpp @@ -55,16 +55,18 @@ int main() { #ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES { - assert(G::n_alive == 0); + G g; + assert(G::n_alive == 1); assert(!G::op_run); - std::thread t0(G(), 5, 5.5); + std::thread t0(g, 5, 5.5); std::thread::id id = t0.get_id(); std::thread t1 = std::move(t0); assert(t1.get_id() == id); assert(t0.get_id() == std::thread::id()); t1.join(); - assert(G::n_alive == 0); + assert(G::n_alive == 1); assert(G::op_run); } + assert(G::n_alive == 0); #endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES } diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp index 20c8da1d..ddf96d09 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp @@ -9,6 +9,9 @@ // // UNSUPPORTED: libcpp-has-no-threads +// NOTE: TSAN will report this test as leaking a thread. +// XFAIL: tsan + // // class thread @@ -53,8 +56,11 @@ int main() { assert(G::n_alive == 0); assert(!G::op_run); - std::thread t((G())); - std::this_thread::sleep_for(std::chrono::milliseconds(250)); + G g; + { + std::thread t(g); + std::this_thread::sleep_for(std::chrono::milliseconds(250)); + } } assert(false); } diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/get_id.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/get_id.pass.cpp index a5ea55a5..5cca7b0b 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/get_id.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/get_id.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); std::thread::id id0 = t0.get_id(); std::thread t1; std::thread::id id1 = t1.get_id(); diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/join.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/join.pass.cpp index 2559303e..0512e49d 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/join.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/join.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); assert(t0.joinable()); t0.join(); assert(!t0.joinable()); diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/joinable.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/joinable.pass.cpp index 351c1cf4..b97839c3 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/joinable.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/joinable.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); assert(t0.joinable()); t0.join(); assert(!t0.joinable()); diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/native_handle.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/native_handle.pass.cpp index 37c2d9c9..c8807a96 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/native_handle.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/native_handle.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); pthread_t pid = t0.native_handle(); assert(pid != 0); t0.join(); diff --git a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/swap.pass.cpp b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/swap.pass.cpp index e8dede17..49d4618e 100644 --- a/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/swap.pass.cpp +++ b/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/swap.pass.cpp @@ -45,7 +45,8 @@ bool G::op_run = false; int main() { { - std::thread t0((G())); + G g; + std::thread t0(g); std::thread::id id0 = t0.get_id(); std::thread t1; std::thread::id id1 = t1.get_id();