generic-library/cxx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix numeric_limits<XXX>::is_modulo for signed arithmetic types. We were reporting true, for all arithmetic types, which is incorrect. Fix the tests which were wrong, too. This fixes PR#20158.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@214371 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Marshall Clow 2014-07-31 01:18:05 +00:00
parent 05d116eb87
commit 15269a8796
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/limits
View File

@ -235,7 +235,7 @@ protected:
static _LIBCPP_CONSTEXPR const bool is_iec559 = false; static _LIBCPP_CONSTEXPR const bool is_iec559 = false;
static _LIBCPP_CONSTEXPR const bool is_bounded = true; static _LIBCPP_CONSTEXPR const bool is_bounded = true;
static _LIBCPP_CONSTEXPR const bool is_modulo = true; static _LIBCPP_CONSTEXPR const bool is_modulo = !_VSTD::is_signed<_Tp>::value;
#if __i386__ || __x86_64__ #if __i386__ || __x86_64__
static _LIBCPP_CONSTEXPR const bool traps = true; static _LIBCPP_CONSTEXPR const bool traps = true;

16
test/language.support/support.limits/limits/numeric.limits.members/is_modulo.pass.cpp
View File

@ -26,24 +26,24 @@ test()
int main() int main()
{ {
test<bool, false>(); test<bool, false>();
test<char, true>(); // test<char, false>(); // don't know
test<signed char, true>(); test<signed char, false>();
test<unsigned char, true>(); test<unsigned char, true>();
test<wchar_t, true>(); // test<wchar_t, false>(); // don't know
#ifndef _LIBCPP_HAS_NO_UNICODE_CHARS #ifndef _LIBCPP_HAS_NO_UNICODE_CHARS
test<char16_t, true>(); test<char16_t, true>();
test<char32_t, true>(); test<char32_t, true>();
#endif // _LIBCPP_HAS_NO_UNICODE_CHARS #endif // _LIBCPP_HAS_NO_UNICODE_CHARS
test<short, true>(); test<short, false>();
test<unsigned short, true>(); test<unsigned short, true>();
test<int, true>(); test<int, false>();
test<unsigned int, true>(); test<unsigned int, true>();
test<long, true>(); test<long, false>();
test<unsigned long, true>(); test<unsigned long, true>();
test<long long, true>(); test<long long, false>();
test<unsigned long long, true>(); test<unsigned long long, true>();
#ifndef _LIBCPP_HAS_NO_INT128 #ifndef _LIBCPP_HAS_NO_INT128
test<__int128_t, true>(); test<__int128_t, false>();
test<__uint128_t, true>(); test<__uint128_t, true>();
#endif #endif
test<float, false>(); test<float, false>();