generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
16,298 Commits 5 Branches 157 Tags 40 MiB
f737e3a3dd
Commit Graph

179 Commits

Author SHA1 Message Date
Steve Holme
f737e3a3dd smtp: Added description comments to all perform based functions 2013-04-16 19:44:53 +01:00
Steve Holme
686586b0f9 smtp: Moved smtp_quit() to be with the other perform functions 2013-04-16 19:44:52 +01:00
Steve Holme
e621a5f6ea smtp: Moved smtp_rcpt_to() to be with the other perform functions 2013-04-16 19:44:49 +01:00
Steve Holme
8093f9541e smtp: Moved smtp_mail() to be with the other perform functions 2013-04-16 19:44:47 +01:00
Steve Holme
651254dcc7 smtp: Updated the coding style of smtp_state_servergreet_resp() 
Updated the coding style, in this function, to be consistant with other
response functions rather then performing a hard return on failure.
 2013-04-15 20:27:47 +01:00
Steve Holme
8723cade21 smtp: Added support for ;auth=<mech> in the URL 
Added support for specifying the preferred authentication mechanism in
the URL as per Internet-Draft 'draft-earhart-url-smtp-00'.
 2013-04-13 16:23:00 +01:00
Steve Holme
ad3fdbc0a4 smtp: Fix compiler warning 
warning: unused variable 'smtp' introduced in commit 73cbd21b5e.
 2013-04-13 00:06:19 +01:00
Steve Holme
73cbd21b5e smtp: Moved parsing of url path into separate function 2013-04-12 23:15:51 +01:00
Steve Holme
059647f398 email: Removed hard returns from init functions 2013-03-09 22:25:40 +00:00
Steve Holme
b482417ac4 email: Updated the function descriptions for the logout / quit functions 
Updated the function description comments following commit 4838d196fd.
 2013-03-09 12:10:01 +00:00
Steve Holme
4838d196fd email: Simplified the logout / quit functions 
Moved the blocking state machine to the disconnect functions so that the
logout / quit functions are only responsible for sending the actual
command needed to logout or quit.

Additionally removed the hard return on failure.
 2013-03-09 11:55:48 +00:00
Steve Holme
f691f9609c email: Tidied up the *_regular_transfer() functions 
Added comments and simplified convoluted dophase_done comparison.
 2013-03-08 23:25:04 +00:00
Steve Holme
e5bb4e86ac email: Simplified nesting of if statements in *_doing() functions 2013-03-08 23:02:20 +00:00
Steve Holme
cc890906b1 email: Minor code tidy up following recent changes 
Removed unwanted braces and added variable initialisation.
 2013-03-07 22:44:10 +00:00
Steve Holme
67b6fa5f95 email: Optimised block_statemach() functions 
Optimised the result test in each of the block_statemach() functions.
 2013-03-07 18:21:58 +00:00
Steve Holme
036366f1ef smtp: Updated the coding style for state changes after a send operation 
Some state changes would be performed after a failure test that
performed a hard return, whilst others would be performed within a test
for success. Updated the code, for consistency, so all instances are
performed within a success test.
 2013-03-03 13:48:22 +00:00
Steve Holme
b4eb08e7fb pop3 / smtp: Small comment tidy up 
Small tidy up to keep some comments consistant across each of the email
protocols.
 2013-02-28 22:27:10 +00:00
Steve Holme
0be2251394 smtp: Corrected debug message for POP3_AUTH_FINAL constant 
Following commit ad3177da24 corrected the debug message in state()
from AUTH to AUTH_FINAL.
 2013-02-28 21:11:02 +00:00
Steve Holme
ad3177da24 smtp: Re-factored the final SMTP_AUTH constant 
Changed the final SMTP_AUTH constant to SMTP_AUTH_FINAL for consistency
with the response function.
 2013-02-27 21:20:55 +00:00
Linus Nielsen Feltzing
0ffefefe7f Remove unused variable in smtp_state_data_resp() 2013-02-26 09:05:25 +01:00
Steve Holme
764b818934 email: Small tidy up following recent changes 2013-02-25 23:00:08 +00:00
Steve Holme
9d45391347 smtp: Removed bytecountp from the per-request structure 
Removed this pointer to a downloaded bytes counter because it was set in
smtp_init() to point to the same variable the transfer functions keep
the count in (k->bytecount), effectively making the code in transfer.c
"*k->bytecountp = k->bytecount" a no-op.
 2013-02-25 22:50:36 +00:00
Steve Holme
7f6c7331b2 email: Additional tidy up of comments following recent changes 2013-02-23 20:02:05 +00:00
Steve Holme
0b795db731 smtp: Removed some FTP heritage leftovers 
Removed user and passwd from the SMTP struct as these cannot be set on
a per-request basis and are leftover from legacy FTP code.

Changed some comments still using FTP terminology.
 2013-02-23 19:46:21 +00:00
Steve Holme
8a468ef222 smtp: Moved the per-request variables to the per-request data structure 
Moved the rcpt variable from the per-connection struct smtp_conn to the
new per-request struct and fixed references accordingly.
 2013-02-23 19:39:22 +00:00
Steve Holme
ed7d438a12 pop3: Introduced a custom SMTP structure for per-request data 
Created a new SMTP structure and changed the type of the smtp proto
variable in connectdata from FTP* to SMTP*.
 2013-02-23 19:31:59 +00:00
Steve Holme
d415327bd7 email: Minor tidy up following IMAP changes 2013-02-23 11:34:52 +00:00
Yang Tse
52605e006c smtp.c: fix enumerated type mixed with another type 2013-02-19 16:53:13 +01:00
Steve Holme
e52fc1e297 email: Tidied up result code variables 
Tidied up result variables to be consistent in name, declaration order
and default values.
 2013-02-16 23:37:50 +00:00
Steve Holme
39b79c6b75 email: Removed unnecessary forward declaration 
Due to the reordering of functions in commit 586f5d3614 the forward
declaration to state_upgrade_tls() are no longer required.
 2013-02-16 10:28:32 +00:00
Daniel Stenberg
c25383ae13 rename "easy" statemachines: call them block instead 
... since they're not used by the easy interface really, I wanted to
remove the association. Also, I unified the pingpong statemachine driver
into a single function with a 'wait' argument: Curl_pp_statemach.
 2013-02-15 11:10:18 +01:00
Steve Holme
4f328b85c3 smtp.c: Fixed a trailing whitespace 
Remove tailing whitespace introduced in commit 7ed689d24a.
 2013-02-14 20:06:03 +00:00
Steve Holme
7ed689d24a smtp: Refactored the smtp_state_auth_resp() function 
Renamed smtp_state_auth_resp() function to match the implementations in
IMAP and POP3.
 2013-02-14 18:15:07 +00:00
Steve Holme
d09d08dc1f email: Tidy up before additional IMAP work 
Replaced two explicit comparisons of CURLE_OK with boolean alternatives.

General tidy up of comments.
 2013-02-13 20:12:21 +00:00
Steve Holme
0c6fa0dd64 smtp: Removed duplicate pingpong structure initialisation 
The smtp_connect() function was setting the member variables of the
pingpong structure twice, once before calling Curl_pp_init() and once
after!
 2013-02-13 18:22:20 +00:00
Steve Holme
52281a10aa email: Post optimisation of endofresp() tidy up 
Removed unnecessary end of line check and return.
 2013-02-12 21:01:50 +00:00
Steve Holme
b56c9eb48e pingpong: Optimised the endofresp() function 
Reworked the pp->endofresp() function so that the conndata, line and
line length are passed down to it just as with Curl_client_write()
rather than each implementation of the function having to query
these values.

Additionally changed the int return type to bool as this is more
representative of the function's usage.
 2013-02-12 18:08:48 +00:00
Steve Holme
586f5d3614 email: Post STARTLS capability code tidy up (Part Three) 
Corrected the order of the upgrade_tls() functions and moved the handler
upgrade and getsock() functions out from the middle of the state related
functions.
 2013-02-11 23:13:50 +00:00
Steve Holme
566a3638fa smtp: Added support for the STARTTLS capability (Part Two) 
Added honoring of the tls_supported flag when starting a TLS upgrade
rather than unconditionally attempting it. If the use_ssl flag is set
to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the
connection will continue to authenticate. If this flag is set to
CURLUSESSL_ALL then the connection will complete with a failure as it
did previously.
 2013-02-10 19:59:42 +00:00
Steve Holme
c76cb3da04 smtp: Added support for the STLS capability (Part One) 
Introduced detection of the STARTTLS capability, in order to add support
for TLS upgrades without unconditionally sending the STARTTLS command.
 2013-02-10 12:19:10 +00:00
Steve Holme
92f7606f29 smtp: Fixed an issue when processing EHLO failure responses (Part 3) 
Follow up fix to commit 62bd217464 to cater for servers that don't
respond with a 250 in their EHLO responses. Additionally updated the
SMTP tests to respond with a 250 response code as per RFC5321.
 2013-02-09 19:01:15 +00:00
Steve Holme
62bd217464 smtp: Fixed an issue when processing EHLO failure responses (Part 2) 
Follow up fix to commit 23d17190ee as EHLO capabilities can exist
within a positive response line.
 2013-02-09 14:32:20 +00:00
Steve Holme
f0bfc0fbd7 smtp: Fixed an issue with missing capabilities after the AUTH line 
Follow up to commit 40f9bb787f to fix missing capabilities after an
AUTH line.
 2013-02-09 14:26:22 +00:00
Steve Holme
23d17190ee smtp: Fixed an issue when processing EHLO failure responses 
Fixed a small issue where smtp_endofresp() would look for capabilities
in the description part of a failure response. In theory a server
shouldn't respond with SIZE or AUTH in an EHLO command's failure
response but if it did then capabilities would be unnecessarily set
before eventually failing.
 2013-02-09 00:22:25 +00:00
Steve Holme
40f9bb787f smtp: Reworked smtp_endofresp() to allow for extra capability detection 2013-02-08 21:19:34 +00:00
Steve Holme
dda53476ca smtp: Renamed smtp_state_auth_passwd_resp() function 
Renamed the login password response function to better describe it's
purpose as well as for consistency with the imap and pop3 modules.
 2013-02-08 20:54:03 +00:00
Steve Holme
e07385f853 smtp: Updated SMTP_AUTH_PASSWD state constant 
Changed the SMTP_AUTH_PASSWD state constant to SMTP_AUTH_LOGIN_PASSWD to
better describe the state as the second part of an AUTH LOGIN command,
as well as for consistency with the imap and pop3 modules.
 2013-02-07 20:37:11 +00:00
Steve Holme
de0410fe9a email: Moved starttls code in separate functions 
To help maintain the readability of the code in imap.c, pop3.c and
smtp.c moved the starttls code into state_starttls() functions.
 2013-02-06 20:02:36 +00:00
Steve Holme
1d22407863 email: Reworked comments in the endofresp() functions 
Tidied up the comments in the endofresp() functions to be more
meaningful prior to release.
 2013-02-05 21:09:34 +00:00
Steve Holme
022e67294e email: Provided extra comments following recent pop3/imap fixes 
Provided additional clarification about the logic of the authenticate()
functions following commit 6b6bdc83bd and b4270a9af1.
 2013-02-04 23:51:36 +00:00