This is done via a TCP socket pair monitored at each negotiate/send/receive
attempt for explicit pipelining.
See gskit.c comments for more information.
Truncated valgrind output capturing the crash follows:
Invalid read of size 8
at 0x628B4A0: PR_Close (priometh.c:104)
by 0x43C088: nss_close (nss.c:1356)
by 0x43C17F: Curl_nss_close (nss.c:1377)
by 0x438F42: Curl_ssl_close (vtls.c:618)
by 0x45460B: Curl_disconnect (url.c:3000)
by 0x42EACA: close_all_connections (multi.c:1887)
by 0x42EB37: curl_multi_cleanup (multi.c:1907)
by 0x44B4CA: Curl_close (url.c:427)
by 0x4282C2: curl_easy_cleanup (easy.c:859)
by 0x41341C: main_free (tool_main.c:206)
by 0x4134F4: main (tool_main.c:260)
Address 0x99afa10 is 0 bytes inside a block of size 48 free'd
at 0x4C29D6A: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x62A2C33: pt_Close (ptio.c:1277)
by 0x43BACD: nspr_io_close (nss.c:1141)
by 0x54D6E25: ssl_DefClose (ssldef.c:203)
by 0x43BACD: nspr_io_close (nss.c:1141)
by 0x54D6E25: ssl_DefClose (ssldef.c:203)
by 0x43C088: nss_close (nss.c:1356)
by 0x43C173: Curl_nss_close (nss.c:1376)
by 0x438F42: Curl_ssl_close (vtls.c:618)
by 0x45460B: Curl_disconnect (url.c:3000)
by 0x42EACA: close_all_connections (multi.c:1887)
by 0x42EB37: curl_multi_cleanup (multi.c:1907)
Block was alloc'd at
at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x6289F71: _PR_Getfd (prfdcach.c:103)
by 0x62A4816: pt_SetMethods.isra.13 (ptio.c:3303)
by 0x62A56E5: PR_ImportTCPSocket (ptio.c:4577)
by 0x43D4D0: nss_setup_connect (nss.c:1733)
by 0x43DDCA: nss_connect_common (nss.c:1929)
by 0x43DF1E: Curl_nss_connect_nonblocking (nss.c:1985)
by 0x4386CE: Curl_ssl_connect_nonblocking (vtls.c:364)
by 0x47F02C: https_proxy_connect (http_proxy.c:58)
by 0x47F086: Curl_proxy_connect (http_proxy.c:74)
by 0x445891: Curl_http_connect (http.c:1348)
by 0x42D613: multi_runsingle (multi.c:1233)
They tend to never get updated anyway so they're frequently inaccurate
and we never go back to revisit them anyway. We document issues to work
on properly in KNOWN_BUGS and TODO instead.
BoringSSL implements `BIO_get_mem_data` as a function, instead of a
macro, and expects the output pointer to be a `char **`. We have to add
an explicit cast to grab the pointer as a `const char **`.
Closes#524
This reverts commit 370ee919b37cc9a46c36428b2bb1527eae5db2bd.
Issue #509 has all the details but it was confirmed that the crash was
not due to this, so the previous commit was wrong.
sk_X509_pop will decrease the size of the stack which means that the loop would
end after having added only half of the certificates.
Also make sure that the X509 certificate is freed in case
SSL_CTX_add_extra_chain_cert fails.
- Change algorithm init to happen after OpenSSL config load.
Additional algorithms may be available due to the user's config so we
initialize the algorithms after the user's config is loaded.
Bug: https://github.com/bagder/curl/issues/447
Reported-by: Denis Feklushkin
If GnuTLS fails to read the certificate then include whatever reason it
provides in the failure message reported to the client.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
The gnutls vtls back-end was previously ignoring any password set via
CURLOPT_KEYPASSWD. Presumably this was because
gnutls_certificate_set_x509_key_file did not support encrypted keys.
gnutls now has a gnutls_certificate_set_x509_key_file2 function that
does support encrypted keys. Let's determine at compile time whether the
available gnutls supports this new function. If it does then use it to
pass the password. If it does not then emit a helpful diagnostic if a
password is set. This is preferable to the previous behaviour of just
failing to read the certificate without giving a reason in that case.
Signed-off-by: Mike Crowe <mac@mcrowe.com>
- Change the designator name we use to show the base64 encoded sha256
hash of the server's public key from 'pinnedpubkey' to
'public key hash'.
Though the server's public key hash is only shown when comparing pinned
public key hashes, the server's hash may not match one of the pinned.
Without this workaround, NSS re-uses a session cache entry despite the
server name does not match. This causes SNI host name to differ from
the actual host name. Consequently, certain servers (e.g. github.com)
respond by 400 to such requests.
Bug: https://bugzilla.mozilla.org/1202264
If strict certificate checking is disabled (CURLOPT_SSL_VERIFYPEER
and CURLOPT_SSL_VERIFYHOST are disabled) do not fail if the server
doesn't present a certificate at all.
Closes#392
MSVC 12 complains:
lib\vtls\openssl.c(1554): warning C4701: potentially uninitialized local
variable 'verstr' used It's a false positive, but as it's normally not,
I have enabled warning-as-error for that warning.
New tool option --ssl-no-revoke.
New value CURLSSLOPT_NO_REVOKE for CURLOPT_SSL_OPTIONS.
Currently this option applies only to WinSSL where we have automatic
certificate revocation checking by default. According to the
ssl-compared chart there are other backends that have automatic checking
(NSS, wolfSSL and DarwinSSL) so we could possibly accommodate them at
some later point.
Bug: https://github.com/bagder/curl/issues/264
Reported-by: zenden2k <zenden2k@gmail.com>
setup-vms.h: More symbols for SHA256, hacks for older VAX
openssl.h: Use OpenSSL OPENSSL_NO_SHA256 macro to allow building on VAX.
openssl.c: Use OpenSSL version checks and OPENSSL_NO_SHA256 macro to
allow building on VAX and 64 bit VMS.
