generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Some systems poll function sets POLLHUP in revents without setting

Browse Source 
POLLIN, and sets POLLERR without setting POLLIN and POLLOUT. In some
libcurl code execution paths this could trigger busy wait loops with
high CPU usage until a timeout condition aborted the loop.

This fix for Curl_poll adresses the above in a libcurl-wide mode.
This commit is contained in:
Yang Tse 2009-09-15 00:07:56 +00:00
parent 7e0b0763fc
commit f7690db37d
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/select.c
View File

@ -398,6 +398,20 @@ int Curl_poll(struct pollfd ufds[], unsigned int nfds, int timeout_ms)
}
} while(r == -1);
if(r < 0)
return -1;
if(r == 0)
return 0;
for (i = 0; i < nfds; i++) {
if(ufds[i].fd == CURL_SOCKET_BAD)
continue;
if(ufds[i].revents & POLLHUP)
ufds[i].revents |= POLLIN;
if(ufds[i].revents & POLLERR)
ufds[i].revents |= (POLLIN|POLLOUT);
}
#else /* HAVE_POLL_FINE */
FD_ZERO(&fds_read);