generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sasl: Corrected missing free of decoded challenge message from 607883f13c

Browse Source
This commit is contained in:
Steve Holme 2014-04-06 14:10:18 +01:00
parent 175b605331
commit f700eb7d9a
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/curl_sasl_sspi.c
View File

@ -95,14 +95,18 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Ensure we have some login credientials as DigestSSP cannot use the current /* Ensure we have some login credientials as DigestSSP cannot use the current
Windows user like NTLMSSP can */ Windows user like NTLMSSP can */
if(!userp || !*userp) if(!userp || !*userp) {
Curl_safefree(chlg);
return CURLE_LOGIN_DENIED; return CURLE_LOGIN_DENIED;
}
/* Query the security package for DigestSSP */ /* Query the security package for DigestSSP */
status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *) TEXT("WDigest"), status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *) TEXT("WDigest"),
&SecurityPackage); &SecurityPackage);
if(status != SEC_E_OK) if(status != SEC_E_OK) {
Curl_safefree(chlg);
return CURLE_NOT_BUILT_IN; return CURLE_NOT_BUILT_IN;
}
/* Calculate our SPN */ /* Calculate our SPN */
spn = aprintf("%s/%s", service, data->easy_conn->host); spn = aprintf("%s/%s", service, data->easy_conn->host);
@ -113,6 +117,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
result = Curl_create_sspi_identity(userp, passwdp, &identity); result = Curl_create_sspi_identity(userp, passwdp, &identity);
if(result) { if(result) {
Curl_safefree(spn); Curl_safefree(spn);
Curl_safefree(chlg);
return result; return result;
} }
@ -127,6 +132,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_sspi_free_identity(&identity); Curl_sspi_free_identity(&identity);
Curl_safefree(spn); Curl_safefree(spn);
Curl_safefree(chlg);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@ -164,6 +170,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
s_pSecFn->FreeCredentialsHandle(&handle); s_pSecFn->FreeCredentialsHandle(&handle);
Curl_sspi_free_identity(&identity); Curl_sspi_free_identity(&identity);
Curl_safefree(spn); Curl_safefree(spn);
Curl_safefree(chlg);
return CURLE_RECV_ERROR; return CURLE_RECV_ERROR;
} }
@ -182,6 +189,9 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Free the SPN */ /* Free the SPN */
Curl_safefree(spn); Curl_safefree(spn);
/* Free the decoeded challenge message */
Curl_safefree(chlg);
return result; return result;
} }