generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

imap: Reversed the logic of the (un)successful tagged SELECT response

Browse Source 
Reversed the logic of the unsuccessful vs successful tagged SELECT
response in imap_state_select_resp() to be more logical to read.
This commit is contained in:
Steve Holme
2013-02-27 20:53:34 +00:00
parent 5b3736b533
commit f53ed631b3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/imap.c
View File

@@ -1233,11 +1233,7 @@ static CURLcode imap_state_select_resp(struct connectdata *conn,
imapc->mailbox_uidvalidity = strdup(tmp); imapc->mailbox_uidvalidity = strdup(tmp);
} }
} }
else if(imapcode != 'O') { else if(imapcode == 'O') {
failf(data, "Select failed");
result = CURLE_LOGIN_DENIED;
}
else {
/* Check if the UIDVALIDITY has been specified and matches */ /* Check if the UIDVALIDITY has been specified and matches */
if(imap->uidvalidity && imapc->mailbox_uidvalidity && if(imap->uidvalidity && imapc->mailbox_uidvalidity &&
strcmp(imap->uidvalidity, imapc->mailbox_uidvalidity)) { strcmp(imap->uidvalidity, imapc->mailbox_uidvalidity)) {
@@ -1251,6 +1247,10 @@ static CURLcode imap_state_select_resp(struct connectdata *conn,
result = imap_fetch(conn); result = imap_fetch(conn);
} }
} }
else {
failf(data, "Select failed");
result = CURLE_LOGIN_DENIED;
}
return result; return result;
} }