generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glob: error out on range overflow

Browse Source 
The new multiply() function detects range value overflows. 32bit
machines will overflow on a 32bit boundary while 64bit hosts support
ranges up to the full 64 bit range.

Added test 1236 to verify.

Bug: http://curl.haxx.se/bug/view.cgi?id=1267
Reported-by: Will Dietz
This commit is contained in:
Daniel Stenberg
2013-08-16 11:52:59 +02:00
parent 5ca96cb844
commit f15a88f2b2
3 changed files with 62 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/data/Makefile.am
View File

@@ -94,6 +94,7 @@ test1208 test1209 test1210 test1211 test1212 test1213 test1214 test1215 \
test1216 test1217 test1218 test1219 \
test1220 test1221 test1222 test1223 test1224 test1225 test1226 test1227 \
test1228 test1229 test1230 test1231 test1232 test1233 test1234 test1235 \
test1236 \
\
test1300 test1301 test1302 test1303 test1304 test1305 test1306 test1307 \
test1308 test1309 test1310 test1311 test1312 test1313 test1314 test1315 \

33
tests/data/test1236 Normal file
View File

@@ -0,0 +1,33 @@
<testcase>
<info>
<keywords>
globbing
FAILURE
</keywords>
</info>
# Server-side
<reply>
</reply>
# Client-side
<client>
<server>
none
</server>
<name>
[] globbing overflowing the range counter
</name>
# 2^62 == 4611686018427387904
<command>
"%HOSTIP:%HTTPPORT/1234[0-1]{" "%HOSTIP:%HTTPPORT/[1-4611686018427387904][1-4611686018427387904]"
</command>
</client>
# Verify data after the test has been "shot"
<verify>
# 3 == CURLE_URL_MALFORMAT
<errorcode>
3
</errorcode>
</verify>
</testcase>