generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

http_digest: Use CURLcode instead of CURLdigest

Browse Source 
To provide consistent behaviour between the various HTTP authentication
functions use CURLcode based error codes for Curl_input_digest()
especially as the calling code doesn't use the specific error code just
that it failed.
This commit is contained in:
Steve Holme
2014-11-05 12:05:34 +00:00
parent 54c8728cd7
commit efe4bab29b
3 changed files with 24 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/http.c
View File

@@ -845,7 +845,7 @@ CURLcode Curl_http_input_auth(struct connectdata *conn, bool proxy,
infof(data, "Ignoring duplicate digest auth header.\n");
}
else {
CURLdigest dig;
CURLcode result;
*availp |= CURLAUTH_DIGEST;
authp->avail |= CURLAUTH_DIGEST;
@@ -853,9 +853,8 @@ CURLcode Curl_http_input_auth(struct connectdata *conn, bool proxy,
* authentication isn't activated yet, as we need to store the
* incoming data from this header in case we are gonna use
* Digest. */
dig = Curl_input_digest(conn, proxy, auth);
if(CURLDIGEST_FINE != dig) {
result = Curl_input_digest(conn, proxy, auth);
if(result) {
infof(data, "Authentication problem. Ignoring this.\n");
data->state.authproblem = TRUE;
}