generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

- Yehoshua Hershberg found a problem that would make libcurl re-use a

Browse Source 
connection with the multi interface even if a previous use of it caused a
  CURLE_PEER_FAILED_VERIFICATION to get returned. I now make sure that failed
  SSL connections properly close the connections.
This commit is contained in:
Daniel Stenberg 2008-08-04 22:07:50 +00:00
parent 3a499099af
commit ed50e3f1b4
4 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@ -6,6 +6,12 @@
Changelog Changelog
Daniel Stenberg (5 Aug 2008)
- Yehoshua Hershberg found a problem that would make libcurl re-use a
connection with the multi interface even if a previous use of it caused a
CURLE_PEER_FAILED_VERIFICATION to get returned. I now make sure that failed
SSL connections properly close the connections.
Daniel Stenberg (4 Aug 2008) Daniel Stenberg (4 Aug 2008)
- Test cases 1051, 1052 and 1055 were added by Daniel Fandrich on July 30 and - Test cases 1051, 1052 and 1055 were added by Daniel Fandrich on July 30 and
proved how PUT and POST with a redirect could lead to a "hang" due to the proved how PUT and POST with a redirect could lead to a "hang" due to the

3
RELEASE-NOTES
View File

@ -47,6 +47,7 @@ This release includes the following bugfixes:
o no longer link with gdi32 on Windows cross-compiled targets o no longer link with gdi32 on Windows cross-compiled targets
o HTTP PUT with -C - sent bad Content-Range: header o HTTP PUT with -C - sent bad Content-Range: header
o HTTP PUT or POST with redirect could lead to hang o HTTP PUT or POST with redirect could lead to hang
o re-use of connections with failed SSL connects in the multi interface
This release includes the following known bugs: This release includes the following known bugs:
@ -67,7 +68,7 @@ advice from friends like these:
Rob Crittenden, Dengminwen, Christopher Palow, Hans-Jurgen May, Rob Crittenden, Dengminwen, Christopher Palow, Hans-Jurgen May,
Phil Pellouchoud, Eduard Bloch, John Lightsey, Stephen Collyer, Tor Arntsen, Phil Pellouchoud, Eduard Bloch, John Lightsey, Stephen Collyer, Tor Arntsen,
Rolland Dudemaine, Phil Blundell, Scott Barrett, Andreas Schuldei, Rolland Dudemaine, Phil Blundell, Scott Barrett, Andreas Schuldei,
Peter Lamberg, David Bau, Pramod Sharma Peter Lamberg, David Bau, Pramod Sharma, Yehoshua Hershberg
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

4
TODO-RELEASE
View File

@ -14,10 +14,6 @@ To be addressed before 7.19.0 (planned release: August 2008)
* Third version of the patch fixing a failure to chose a proper data * Third version of the patch fixing a failure to chose a proper data
type submitted to the mailing list 2008-08-04. type submitted to the mailing list 2008-08-04.
146 - Yehoshua Hershberg's re-using of connections that failed with
CURLE_PEER_FAILED_VERIFICATION
148 - Introduction of m4/reentrant.m4 is triggering some problems on Solaris 148 - Introduction of m4/reentrant.m4 is triggering some problems on Solaris
systems. The problem manifests when buildconf runs aclocal, at some point systems. The problem manifests when buildconf runs aclocal, at some point
aclocal fails when using GNU m4 version 1.4.5 it runs out of memory. If aclocal fails when using GNU m4 version 1.4.5 it runs out of memory. If

5
lib/http.c
View File

@ -1815,8 +1815,11 @@ static CURLcode https_connecting(struct connectdata *conn, bool *done)
/* perform SSL initialization for this socket */ /* perform SSL initialization for this socket */
result = Curl_ssl_connect_nonblocking(conn, FIRSTSOCKET, done); result = Curl_ssl_connect_nonblocking(conn, FIRSTSOCKET, done);
if(result) if(result) {
conn->bits.close = TRUE; /* a failed connection is marked for closure
to prevent (bad) re-use or similar */
return result; return result;
}
return CURLE_OK; return CURLE_OK;
} }