generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SASL: fix compiler warnings

Browse Source 
comparison between signed and unsigned integer expressions

suggest parentheses around '&&' within '||' (twice)
This commit is contained in:
Daniel Stenberg
2013-09-04 22:32:57 +02:00
parent 2eabb7d590
commit e9de8e78f0
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/curl_sasl.h
View File

@@ -36,7 +36,7 @@
/* Authentication mechanism values */ /* Authentication mechanism values */
#define SASL_AUTH_NONE 0 #define SASL_AUTH_NONE 0
#define SASL_AUTH_ANY ~0 #define SASL_AUTH_ANY ~0U
/* This is used to generate a base64 encoded PLAIN authentication message */ /* This is used to generate a base64 encoded PLAIN authentication message */
CURLcode Curl_sasl_create_plain_message(struct SessionHandle *data, CURLcode Curl_sasl_create_plain_message(struct SessionHandle *data,

6
lib/imap.c
View File

@@ -579,9 +579,9 @@ static CURLcode imap_perform_authenticate(struct connectdata *conn)
} }
else else
#endif #endif
if((imapc->authmechs & SASL_MECH_XOAUTH2) && if(((imapc->authmechs & SASL_MECH_XOAUTH2) &&
(imapc->prefmech & SASL_MECH_XOAUTH2) && (imapc->prefmech & SASL_MECH_XOAUTH2) &&
(imapc->prefmech != SASL_AUTH_ANY) || conn->xoauth2_bearer) { (imapc->prefmech != SASL_AUTH_ANY)) || conn->xoauth2_bearer) {
mech = "XOAUTH2"; mech = "XOAUTH2";
state1 = IMAP_AUTHENTICATE_XOAUTH2; state1 = IMAP_AUTHENTICATE_XOAUTH2;
state2 = IMAP_AUTHENTICATE_FINAL; state2 = IMAP_AUTHENTICATE_FINAL;

6
lib/smtp.c
View File

@@ -500,9 +500,9 @@ static CURLcode smtp_perform_authenticate(struct connectdata *conn)
} }
else else
#endif #endif
if((smtpc->authmechs & SASL_MECH_XOAUTH2) && if(((smtpc->authmechs & SASL_MECH_XOAUTH2) &&
(smtpc->prefmech & SASL_MECH_XOAUTH2) && (smtpc->prefmech & SASL_MECH_XOAUTH2) &&
(smtpc->prefmech != SASL_AUTH_ANY) || conn->xoauth2_bearer) { (smtpc->prefmech != SASL_AUTH_ANY)) || conn->xoauth2_bearer) {
mech = "XOAUTH2"; mech = "XOAUTH2";
state1 = SMTP_AUTH_XOAUTH2; state1 = SMTP_AUTH_XOAUTH2;
state2 = SMTP_AUTH_FINAL; state2 = SMTP_AUTH_FINAL;