generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed a couple of out of memory leaks and a segfault in the SMTP code.

Browse Source
This commit is contained in:
Dan Fandrich 2010-02-25 08:07:06 +00:00
parent 4ad984043e
commit cce81a7f45
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -6,6 +6,9 @@
Changelog Changelog
Daniel Fandrich (25 Feb 2010)
- Fixed a couple of out of memory leaks and a segfault in the SMTP code.
Yang Tse (25 Feb 2010) Yang Tse (25 Feb 2010)
- I fixed bug report #2958074 indicating - I fixed bug report #2958074 indicating
(http://curl.haxx.se/bug/view.cgi?id=2958074) that curl on Windows with (http://curl.haxx.se/bug/view.cgi?id=2958074) that curl on Windows with

3
lib/smtp.c
View File

@ -724,6 +724,8 @@ static CURLcode smtp_connect(struct connectdata *conn,
/* url decode the path and use it as domain with EHLO */ /* url decode the path and use it as domain with EHLO */
smtpc->domain = curl_easy_unescape(conn->data, path, 0, &len); smtpc->domain = curl_easy_unescape(conn->data, path, 0, &len);
if (!smtpc->domain)
return CURLE_OUT_OF_MEMORY;
/* When we connect, we start in the state where we await the server greeting /* When we connect, we start in the state where we await the server greeting
*/ */
@ -917,6 +919,7 @@ static CURLcode smtp_disconnect(struct connectdata *conn)
/* The SMTP session may or may not have been allocated/setup at this /* The SMTP session may or may not have been allocated/setup at this
point! */ point! */
if (smtpc->pp.conn)
(void)smtp_quit(conn); /* ignore errors on the LOGOUT */ (void)smtp_quit(conn); /* ignore errors on the LOGOUT */
Curl_pp_disconnect(&smtpc->pp); Curl_pp_disconnect(&smtpc->pp);