generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

FormAdd: precaution against memdup() of NULL pointer

Browse Source 
Coverity CID 252518. This function is in general far too complicated for
its own good and really should be broken down into several smaller
funcitons instead - but I'm adding this protection here now since it
seems there's a risk the code flow can end up here and dereference a
NULL pointer.
This commit is contained in:
Daniel Stenberg
2014-10-08 13:53:41 +02:00
parent eb1e3a3985
commit b74205d022
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/formdata.c
View File

@@ -689,7 +689,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
} }
if(!(form->flags & (HTTPPOST_FILENAME | HTTPPOST_READFILE | if(!(form->flags & (HTTPPOST_FILENAME | HTTPPOST_READFILE |
HTTPPOST_PTRCONTENTS | HTTPPOST_PTRBUFFER | HTTPPOST_PTRCONTENTS | HTTPPOST_PTRBUFFER |
HTTPPOST_CALLBACK)) ) { HTTPPOST_CALLBACK)) && form->value) {
/* copy value (without strdup; possibly contains null characters) */ /* copy value (without strdup; possibly contains null characters) */
form->value = memdup(form->value, form->contentslength); form->value = memdup(form->value, form->contentslength);
if(!form->value) { if(!form->value) {