generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

- Tom Mueller correctly reported in bug report

Browse Source 
(http://curl.haxx.se/bug/view.cgi?id=2870221) that libcurl returned an
  incorrect return code from the internal trynextip() function which caused
  him grief. This is a regression that was introduced in 7.19.1 and I find it
  strange it hasn't hit us harder, but I won't persue into figuring out
  exactly why.
This commit is contained in:
Daniel Stenberg 2009-10-01 07:59:45 +00:00
parent 492aed1450
commit b233957885
3 changed files with 10 additions and 2 deletions

7
CHANGES

@ -7,6 +7,13 @@
Changelog Changelog
Daniel Stenberg (1 Oct 2009) Daniel Stenberg (1 Oct 2009)
- Tom Mueller correctly reported in bug report #2870221
(http://curl.haxx.se/bug/view.cgi?id=2870221) that libcurl returned an
incorrect return code from the internal trynextip() function which caused
him grief. This is a regression that was introduced in 7.19.1 and I find it
strange it hasn't hit us harder, but I won't persue into figuring out
exactly why.
- Constantine Sapuntzakis: The current implementation will always set - Constantine Sapuntzakis: The current implementation will always set
SO_SNDBUF to CURL_WRITE_SIZE even if the SO_SNDBUF starts out larger. The SO_SNDBUF to CURL_WRITE_SIZE even if the SO_SNDBUF starts out larger. The
patch doesn't do a setsockopt if SO_SNDBUF is already greater than patch doesn't do a setsockopt if SO_SNDBUF is already greater than

3
RELEASE-NOTES

@ -34,6 +34,7 @@ This release includes the following bugfixes:
o received cookies without explicit path got saved wrong if the URL had a o received cookies without explicit path got saved wrong if the URL had a
query part query part
o don't shrink SO_SNDBUF on windows for those who have it set large already o don't shrink SO_SNDBUF on windows for those who have it set large already
o connect next bug
This release includes the following known bugs: This release includes the following known bugs:
@ -45,6 +46,6 @@ advice from friends like these:
Karl Moerder, Kamil Dudka, Krister Johansen, Andre Guibert de Bruet, Karl Moerder, Kamil Dudka, Krister Johansen, Andre Guibert de Bruet,
Michal Marek, Eric Wong, Guenter Knauf, Peter Sylvester, Daniel Johnson, Michal Marek, Eric Wong, Guenter Knauf, Peter Sylvester, Daniel Johnson,
Claes Jakobsson, Sven Anders, Chris Mumford, John P. McCaskey, Claes Jakobsson, Sven Anders, Chris Mumford, John P. McCaskey,
Constantine Sapuntzakis Constantine Sapuntzakis, Michael Stillwell, Tom Mueller
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

2
lib/connect.c

@ -502,7 +502,7 @@ static bool trynextip(struct connectdata *conn,
/* store the new socket descriptor */ /* store the new socket descriptor */
conn->sock[sockindex] = sockfd; conn->sock[sockindex] = sockfd;
conn->ip_addr = ai; conn->ip_addr = ai;
break; return FALSE;
} }
ai = ai->ai_next; ai = ai->ai_next;
} }