generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

curl_multi_cleanup: remove superfluous NULL assigns

Browse Source 
... as the struct is free()d in the end anyway. It was first pointed out
to me that one of the ->msglist assignments were supposed to have been
->pending but was a copy and paste mistake when I realized none of the
clearing of pointers had to be there.
This commit is contained in:
Daniel Stenberg 2014-09-02 23:44:42 +02:00
parent 3c8c873252
commit a6c48c8be7
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/multi.c
View File

@ -1881,22 +1881,12 @@ CURLMcode curl_multi_cleanup(CURLM *multi_handle)
multi->closure_handle->dns.hostcache); multi->closure_handle->dns.hostcache);
Curl_close(multi->closure_handle); Curl_close(multi->closure_handle);
multi->closure_handle = NULL;
} }
Curl_hash_destroy(multi->sockhash); Curl_hash_destroy(multi->sockhash);
multi->sockhash = NULL;
Curl_conncache_destroy(multi->conn_cache); Curl_conncache_destroy(multi->conn_cache);
multi->conn_cache = NULL;
/* remove the pending list of messages */
Curl_llist_destroy(multi->msglist, NULL); Curl_llist_destroy(multi->msglist, NULL);
multi->msglist = NULL;
/* remove the pending handles queue */
Curl_llist_destroy(multi->pending, NULL); Curl_llist_destroy(multi->pending, NULL);
multi->msglist = NULL;
/* remove all easy handles */ /* remove all easy handles */
data = multi->easyp; data = multi->easyp;
@ -1917,7 +1907,6 @@ CURLMcode curl_multi_cleanup(CURLM *multi_handle)
} }
Curl_hash_destroy(multi->hostcache); Curl_hash_destroy(multi->hostcache);
multi->hostcache = NULL;
/* Free the blacklists by setting them to NULL */ /* Free the blacklists by setting them to NULL */
Curl_pipeline_set_site_blacklist(NULL, &multi->pipelining_site_bl); Curl_pipeline_set_site_blacklist(NULL, &multi->pipelining_site_bl);